Skip to content

Conversation

thomasboussekey
Copy link
Contributor

and fix markdown warnings in README

and fix markdown warnings in README
README.md Outdated

In order to run a basic container capable of serving a PostGIS-enabled database, start a container as follows:

```sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These code blocks seem to be rendering incorrectly. Maybe because they are indented?

README.md Outdated
* Note that ports which are not bound to the host (i.e., `-p 5432:5432` instead of `-p 127.0.0.1:5432:5432`) will be accessible from the outside. This also applies if you configured UFW to block this specific port, as Docker manages its own iptables rules. ( [Read More](https://docs.docker.com/network/iptables/) )

#### Recomendations:
### Recomendations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fix opportunity: I believe "Recomendations" should be spelled "Recommendations"

Copy link
Contributor

@phillipross phillipross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this and cleaning up. I've added two comments as requests for changes.

@ImreSamu
Copy link
Member

Thank you very much for the PR!

I have two small pieces of feedback:

1.) For Postgres >=18 it is probably better to recommend using /var/lib/postgresql instead of /var/lib/postgresql/18/docker.
see: docker-library/postgres#1364 (comment)

I tested with:

  • docker run -d -v $(pwd)/gisdata:/var/lib/postgresql -e POSTGRES_PASSWORD=test postgis/postgis:18-3.6

and inside the container the data is automatically placed in the new path:
fixing permissions on existing directory /var/lib/postgresql/18/docker ... ok
pg_ctl -D /var/lib/postgresql/18/docker -l logfile start

On the host I can also see the files created under ./gisdata/18/docker/:

# ls ./gisdata/18/docker/
base          pg_dynshmem    pg_logical    pg_replslot   pg_stat      pg_tblspc    pg_wal                postgresql.conf
global        pg_hba.conf    pg_multixact  pg_serial     pg_stat_tmp  pg_twophase  pg_xact               postmaster.opts
pg_commit_ts  pg_ident.conf  pg_notify     pg_snapshots  pg_subtrans  PG_VERSION   postgresql.auto.conf  postmaster.pid

So it looks like we should really follow the upstream suggestion, since that path is version-independent.
But please also double-check this on your side.


I usually refresh the README.md table with the one generated by ./update.sh.
That means the current table formatting will be overwritten during the next update.
I just wanted to mention this in advance, so please don’t take it personally if the formatting gets replaced later.


From the above, my first remark is probably the more important one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants