Skip to content

Conversation

thomasboussekey
Copy link
Contributor

No description provided.

Copy link
Contributor

@phillipross phillipross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I believe @ImreSamu is away and has limited availability at the moment, but I'll hold off on merging this PR until later this evening US/Eastern time after I've had a chance to run some smoke tests. Thanks again!

@ImreSamu ImreSamu self-requested a review September 26, 2025 14:23
Copy link
Member

@ImreSamu ImreSamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I tested with ./update.sh and everything looks good.

@ImreSamu
Copy link
Member

ImreSamu commented Sep 26, 2025

One comment: PG18 + PGDATA has changed, and we should also document this on our side. ( README.md ? )

The key point:
* For version 18 the path is : /var/lib/postgresql/18/docker

@thomasboussekey
Copy link
Contributor Author

One comment: PG18 + PGDATA has changed, and we should also document this on our side. ( README.md ? )

The key point:

  • For version 18 the path is : /var/lib/postgresql/18/docker

It can maybe be handled with a new column into the _dockerlists_${optimized}.md tables 🤔

Like:

| DockerHub image | Dockerfile | OS | Postgres | PostGIS | PgData |
| --------------- | ---------- | -- | -------- | ------- | ------ |

@phillipross
Copy link
Contributor

In my opinion it would be sufficient to document the difference by placing comments in the "Supported Environment Variables" section of README.md that highlights the PGDATA difference new in v18 along with a link to the upstream explanation of it that provides more details.

@phillipross
Copy link
Contributor

I'll merge this PR as I'd like for it not to go stale. We can address the PGDATA note in docs in a follow-up PR 👍

@phillipross phillipross merged commit 4668485 into postgis:master Sep 27, 2025
31 checks passed
@thomasboussekey
Copy link
Contributor Author

I'll merge this PR as I'd like for it not to go stale. We can address the PGDATA note in docs in a follow-up PR 👍

Hi Phillip,

I've created PR #431 in order to document this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants