-
Notifications
You must be signed in to change notification settings - Fork 489
feat: Add Pg18 GA #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Pg18 GA #430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I believe @ImreSamu is away and has limited availability at the moment, but I'll hold off on merging this PR until later this evening US/Eastern time after I've had a chance to run some smoke tests. Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I tested with ./update.sh
and everything looks good.
One comment: PG18 + PGDATA has changed, and we should also document this on our side. ( README.md ? )
|
It can maybe be handled with a new column into the Like:
|
In my opinion it would be sufficient to document the difference by placing comments in the "Supported Environment Variables" section of README.md that highlights the PGDATA difference new in v18 along with a link to the upstream explanation of it that provides more details. |
I'll merge this PR as I'd like for it not to go stale. We can address the PGDATA note in docs in a follow-up PR 👍 |
Hi Phillip, I've created PR #431 in order to document this change |
No description provided.