Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ch4/ofi: Include NIC information in error messages #7224

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ch4/ofi: Include NIC information in error messages #7224

wants to merge 2 commits into from

Commits on Nov 25, 2024

  1. ch4/ofi: Remove redundant error info 

    The MPIR error checking macros already add __LINE__ and __func__
information when an error is reported. __SHORT_FILE__ is not necessary
since we have the function name, which any decent editor can find
automatically.
    @raffenet
    raffenet committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    7be8fb0 View commit details
    Browse the repository at this point in the history

  2. ch4/ofi: Add NIC information to error output 

    On systems with multiple NICs, it could be helpful to know which NIC an
error was detected on in case there are hardware issues that need
investigating. Add NIC information to error checking macros. For now, we
report the default NIC used by each process. TODO: extend to support
multi-nic usage and take the device number as input for more
fine-grained reporting.
    @raffenet
    raffenet committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    e71f330 View commit details
    Browse the repository at this point in the history