ch4/ofi: Include NIC information in error messages #7224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test:mpich/ch4/ofi |
The MPIR error checking macros already add __LINE__ and __func__ information when an error is reported. __SHORT_FILE__ is not necessary since we have the function name, which any decent editor can find automatically.
On systems with multiple NICs, it could be helpful to know which NIC an error was detected on in case there are hardware issues that need investigating. Add NIC information to error checking macros. For now, we report the default NIC used by each process. TODO: extend to support multi-nic usage and take the device number as input for more fine-grained reporting.
|
test:mpich/ch4/ofi |
hzhou
reviewed
Nov 25, 2024
| @@ -38,6 +38,9 @@ ATTRIBUTE((unused)); | |||
|
|
|||
| #define MPIDI_OFI_WIN(win) ((win)->dev.netmod.ofi) | |||
|
|
|||
| #define MPIDI_OFI_NIC_NAME(nic) (MPIDI_OFI_global.prov_use[nic]->domain_attr->name) | |||
| #define MPIDI_OFI_DEFAULT_NIC_NAME (MPIDI_OFI_NIC_NAME(0)) | |||
There was a problem hiding this comment.
I worry that in the case we are using non-default nic, then we will be providing misleading information.
There was a problem hiding this comment.
I'll add a patch to use explicit info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
On systems with multiple NICs, it could be helpful to know which NIC an
error was detected on in case there are hardware issues that need
investigating. Add NIC information to error checking macros. For now, we
report the default NIC used by each process. TODO: extend to support
multi-nic usage and take the device number as input for more
fine-grained reporting.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.