MSBuild common properties #3843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s2quake
force-pushed
the
chore/common-properties
branch
2 times, most recently
from
e809dda
to
cd21fb3
Compare
s2quake
force-pushed
the
chore/common-properties
branch
3 times, most recently
from
8d9e289
to
070e243
Compare
s2quake
force-pushed
the
chore/common-properties
branch
5 times, most recently
from
ad443f0
to
5d09b93
Compare
s2quake
force-pushed
the
chore/common-properties
branch
2 times, most recently
from
9173b63
to
ea25c84
Compare
s2quake
force-pushed
the
chore/common-properties
branch
from
ea25c84
to
973a13f
Compare
Merged
s2quake
force-pushed
the
chore/common-properties
branch
from
973a13f
to
d0e35b0
Compare
riemannulus
previously approved these changes
Jul 1, 2024
s2quake
force-pushed
the
chore/common-properties
branch
from
a2bcc0c
to
f87d0fa
Compare
s2quake
force-pushed
the
chore/common-properties
branch
from
66704b3
to
11f7a73
Compare
s2quake
force-pushed
the
chore/common-properties
branch
from
11f7a73
to
ad61add
Compare
riemannulus
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corresponds to
step2of issue #3830 and includes.Directory.Build.propsin the solutions path defines common properties for the entire project.TargetFrameworkproperty isnet6.0.TargetFrameworksused when running thedotnet packcommand is alsonet6.0, but theTargetFrameworksof the project in src has the following values:netstandard2.0;netstandard2.1;netcoreapp3.1;net6.0.TargetFrameworkvalue isnet6.0, some of the code has been branched using #if #endif.