chore: CheckForOverflowUnderflow, ProduceReferenceAssembly, Documenta…

…tionFile.
planetarium · Jun 21, 2024 · 8d9e289 · 8d9e289
1 parent 26c6feb
commit 8d9e289
Show file tree

Hide file tree

Showing 17 changed files with 1 addition and 20 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -26,6 +26,7 @@
     <RequireLicenseAcceptance>true</RequireLicenseAcceptance>
     <GeneratePackageOnBuild Condition="'$(Configuration)'!='Debug'">true</GeneratePackageOnBuild>
     <CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)Libplanet.ruleset</CodeAnalysisRuleSet>
+    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
 
     <PackageReleaseNotes>https://github.com/planetarium/libplanet/blob/main/CHANGES.md</PackageReleaseNotes>
     <PackageTags>multiplayer online game;game;blockchain</PackageTags>

diff --git a/src/Libplanet.Crypto.Secp256k1/Libplanet.Crypto.Secp256k1.csproj b/src/Libplanet.Crypto.Secp256k1/Libplanet.Crypto.Secp256k1.csproj
@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <LangVersion>10</LangVersion>
-    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NoWarn>$(NoWarn);NU5104</NoWarn>
   </PropertyGroup>

diff --git a/src/Libplanet.Net/Libplanet.Net.csproj b/src/Libplanet.Net/Libplanet.Net.csproj
@@ -8,8 +8,6 @@
   <PropertyGroup>
     <ProduceReferenceAssembly>true</ProduceReferenceAssembly>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <DocumentationFile>bin\$(Configuration)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
-    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NoWarn>$(NoWarn);S4035;CS0660;CS0661;S3875;CS1591;NU5104;MEN001</NoWarn>
     <!-- FIXME: S4035 and CS1591 should be turned on eventually. -->

diff --git a/src/Libplanet.RocksDBStore/Libplanet.RocksDBStore.csproj b/src/Libplanet.RocksDBStore/Libplanet.RocksDBStore.csproj
@@ -6,9 +6,7 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <ProduceReferenceAssembly>true</ProduceReferenceAssembly>
     <Nullable>enable</Nullable>
-    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NoWarn>$(NoWarn);NU5104</NoWarn>
   </PropertyGroup>

diff --git a/src/Libplanet.Stun/Libplanet.Stun.csproj b/src/Libplanet.Stun/Libplanet.Stun.csproj
@@ -6,8 +6,6 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <ProduceReferenceAssembly>true</ProduceReferenceAssembly>
-    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NoWarn>$(NoWarn);MEN001</NoWarn>
   </PropertyGroup>

diff --git a/src/Libplanet/Libplanet.csproj b/src/Libplanet/Libplanet.csproj
@@ -11,8 +11,6 @@ https://docs.libplanet.io/</Description>
   <PropertyGroup>
     <ProduceReferenceAssembly>true</ProduceReferenceAssembly>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <DocumentationFile>bin\$(Configuration)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
-    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NoWarn>$(NoWarn);S4035;CS1591;NU5104;MEN001;NU1902</NoWarn>
     <!-- FIXME: S4035 and CS1591 should be turned on eventually. -->

diff --git a/test/Libplanet.Analyzers.Tests/Libplanet.Analyzers.Tests.csproj b/test/Libplanet.Analyzers.Tests/Libplanet.Analyzers.Tests.csproj
@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <Nullable>disable</Nullable>
-    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NoWarn>$(NoWarn);SA1401</NoWarn>
   </PropertyGroup>

diff --git a/test/Libplanet.Net.Tests/Libplanet.Net.Tests.csproj b/test/Libplanet.Net.Tests/Libplanet.Net.Tests.csproj
@@ -1,7 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NoWarn>$(NoWarn);SA1401;SYSLIB0011</NoWarn>
   </PropertyGroup>

diff --git a/test/Libplanet.RocksDBStore.Tests/Libplanet.RocksDBStore.Tests.csproj b/test/Libplanet.RocksDBStore.Tests/Libplanet.RocksDBStore.Tests.csproj
@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <Nullable>disable</Nullable>
-    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 

diff --git a/test/Libplanet.Stun.Tests/Libplanet.Stun.Tests.csproj b/test/Libplanet.Stun.Tests/Libplanet.Stun.Tests.csproj
@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <Nullable>disable</Nullable>
-    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 

diff --git a/test/Libplanet.Tests/Libplanet.Tests.csproj b/test/Libplanet.Tests/Libplanet.Tests.csproj
@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <Nullable>disable</Nullable>
-    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NoWarn>$(NoWarn);SA1401;SYSLIB0011</NoWarn>
   </PropertyGroup>

diff --git a/tools/Libplanet.Analyzers/Libplanet.Analyzers.csproj b/tools/Libplanet.Analyzers/Libplanet.Analyzers.csproj
@@ -8,7 +8,6 @@
 
   <PropertyGroup>
     <IncludeBuildOutput>false</IncludeBuildOutput>
-    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NoWarn>$(NoWarn);NU5128</NoWarn>
     <IsPackable>true</IsPackable>

diff --git a/tools/Libplanet.Benchmarks/Libplanet.Benchmarks.csproj b/tools/Libplanet.Benchmarks/Libplanet.Benchmarks.csproj
@@ -4,7 +4,6 @@
     <Nullable>disable</Nullable>
     <OutputType>Exe</OutputType>
     <IsPackable>false</IsPackable>
-    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 

diff --git a/tools/Libplanet.Explorer.Cocona/Libplanet.Explorer.Cocona.csproj b/tools/Libplanet.Explorer.Cocona/Libplanet.Explorer.Cocona.csproj
@@ -1,7 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NoWarn>$(NoWarn);CS1591;S1118;SA1118</NoWarn>
     </PropertyGroup>

diff --git a/tools/Libplanet.Explorer/Libplanet.Explorer.csproj b/tools/Libplanet.Explorer/Libplanet.Explorer.csproj
@@ -3,7 +3,6 @@
   <PropertyGroup>
     <NoWarn>$(NoWarn);NU1701;NU5104;SA1118</NoWarn>
     <CodeAnalysisRuleSet>..\..\Libplanet.Explorer.ruleset</CodeAnalysisRuleSet>
-    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 

diff --git a/tools/Libplanet.Extensions.Cocona/Libplanet.Extensions.Cocona.csproj b/tools/Libplanet.Extensions.Cocona/Libplanet.Extensions.Cocona.csproj
@@ -1,7 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NoWarn>$(NoWarn);CS1591;S1118;SA1118</NoWarn>
   </PropertyGroup>

diff --git a/tools/Libplanet.Tools/Libplanet.Tools.csproj b/tools/Libplanet.Tools/Libplanet.Tools.csproj
@@ -11,7 +11,6 @@
 
   <PropertyGroup>
     <ToolCommandName>planet</ToolCommandName>
-    <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NoWarn>$(NoWarn);CS1591;S1118;SA1118</NoWarn>
     </PropertyGroup>