-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkp/pkp-lib#10444 Improve dialog component design #415
Open
blesildaramirez
wants to merge
8
commits into
pkp:main
Choose a base branch
from
blesildaramirez:i10444
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Oct 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0e1132d - Browse repository at this point
Copy the full SHA 0e1132dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1ee097 - Browse repository at this point
Copy the full SHA f1ee097View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf371b9 - Browse repository at this point
Copy the full SHA bf371b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5af3052 - Browse repository at this point
Copy the full SHA 5af3052View commit details -
pkp/pkp-lib#10444 Add isDismissible prop to the Dialog component, and…
… add the X button when there are no actions in the props
Configuration menu - View commit details
-
Copy full SHA for 220ae0b - Browse repository at this point
Copy the full SHA 220ae0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12f83dd - Browse repository at this point
Copy the full SHA 12f83ddView commit details -
pkp/pkp-lib#10444 Update Dialog component to add basic modalStyle and…
… add documentation how the styles are used
Configuration menu - View commit details
-
Copy full SHA for cb36200 - Browse repository at this point
Copy the full SHA cb36200View commit details -
pkp/pkp-lib#10444 Remove computed defination of default modalStyle in…
… Dialog component
Configuration menu - View commit details
-
Copy full SHA for cf771a1 - Browse repository at this point
Copy the full SHA cf771a1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.