pkp/pkp-lib#10444 Improve dialog component design #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blesildaramirez
force-pushed
the
i10444
branch
2 times, most recently
from
5f25cff
to
500adf1
Compare
blesildaramirez
force-pushed
the
i10444
branch
3 times, most recently
from
96f6396
to
c9c44c7
Compare
blesildaramirez
force-pushed
the
i10444
branch
from
c9c44c7
to
6d8d431
Compare
… add the X button when there are no actions in the props
… add documentation how the styles are used
… Dialog component
blesildaramirez
force-pushed
the
i10444
branch
from
b40ca0f
to
cf771a1
Compare
blesildaramirez
commented
Oct 21, 2024
| @@ -325,7 +328,7 @@ export default { | |||
| title: mailable ? mailable.name : '', | |||
| mailable: this.currentMailable, | |||
| onOpenTemplate: this.openTemplate, | |||
| onConfirmResetTemplate: this.confirmRemoveTemplate, | |||
| onConfirmResetTemplate: this.confirmResetTemplate, | |||
There was a problem hiding this comment.
Note: This is supposed to open this modal (confirmResetTemplate) to confirm resetting an email template. Including this fix on this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.