-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkp/pkp-lib#9744 [OJS] Migrate older Tables to newer Table API #4378
Merged
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
83a5306
pkp/pkp-lib#9744 Migrate stats issues table to use new table component
blesildaramirez 27929b7
pkp/pkp-lib#9744 Inject new pages for jobs, failed jobs and failed jo…
blesildaramirez 08dcc1b
pkp/pkp-lib#9744 Update issues.tpl to add labelled-by and no-content …
blesildaramirez 3d17bdc
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
blesildaramirez 61c63ad
pkp/pkp-lib#9744 Remove registration of pages components as they are …
blesildaramirez 2aa7d3a
pkp/pkp-lib#9744 Update table component names in issues template
blesildaramirez 8636f2e
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
blesildaramirez 8fb14d9
pkp/pkp-lib#9744 Rename use of table components from stats issues tem…
blesildaramirez ef9455c
pkp/pkp-lib#9744 Remove table-row and table-cell when passing slot to…
blesildaramirez 2bda77f
pkp/pkp-lib#9744 Submodule update ##blesildaramirez/i9744##
blesildaramirez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule pkp
updated
4 files
+4 −4 | js/load.js | |
+16 −16 | templates/stats/context.tpl | |
+12 −12 | templates/stats/editorial.tpl | |
+20 −21 | templates/stats/publications.tpl |
Submodule ui-library
updated
10 files
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ops.. here you can just use table-cell.
Reason why we expose the components with pkp prefix globally is so plugins can use them.
On our own pages&components we always import and register them locally. So for stats you are adding table-cell via 'components:'.. therefore no need to prefix that.
Also the no-content thingy is already supposed to insert correct row and cell with correct colspan. So you should just put there the spinner. But if its not working as expected let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I updated the component names now to use the local version. And remove the table-row and table-cell for the no-content slot.