pkp/pkp-lib#9744 [OJS] Migrate older Tables to newer Table API #4378
Conversation
|
|
…b details pages
…slot for Table component
| import FailedJobDetailsPage from '@/components/Container/FailedJobDetailsPage.vue'; | ||
| import JobsPage from '@/pages/jobs/JobsPage.vue'; | ||
| import FailedJobsPage from '@/pages/jobs/FailedJobsPage.vue'; | ||
| import FailedJobDetailsPage from '@/pages/jobs/FailedJobDetailsPage.vue'; | ||
| import DashboardPage from '@/pages/dashboard/DashboardPage.vue'; |
There was a problem hiding this comment.
I think, these should not be necessary because there are now imported via Page.vue?
templates/stats/issues.tpl
Outdated
| <table-row class="pkpStats__noRecords"> | ||
| <table-cell :colspan="tableColumns.length" class="!py-8 !px-4 !text-center"> | ||
| <pkp-table-row class="pkpStats__noRecords"> | ||
| <pkp-table-cell :colspan="tableColumns.length" class="!py-8 !px-4 !text-center"> | ||
| <template v-if="isLoadingItems"> |
There was a problem hiding this comment.
Ops.. here you can just use table-cell.
Reason why we expose the components with pkp prefix globally is so plugins can use them.
On our own pages&components we always import and register them locally. So for stats you are adding table-cell via 'components:'.. therefore no need to prefix that.
Also the no-content thingy is already supposed to insert correct row and cell with correct colspan. So you should just put there the spinner. But if its not working as expected let me know.
There was a problem hiding this comment.
Thanks, I updated the component names now to use the local version. And remove the table-row and table-cell for the no-content slot.
No description provided.