-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9151 Add mod runtime and IDB error events to lexicon #9345
Open
mnholtz
wants to merge
9
commits into
main
Choose a base branch
from
dev/9151_handle_events
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+48
−1
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
72bec5c
delete GoogleFilePickerEvent
mnholtz bad0e8f
add support for hiding events in the lexicon, and add entry for Googl…
mnholtz 3c8aaa4
add description for hidden property on LexiconEventEntry
mnholtz 67e1fef
add HandleContextMenu to lexicon
mnholtz d4c7853
add HandleQuickBar event to lexicon
mnholtz c8f92f1
add IDB_RECLAIM_QUOTA event to lexicon
mnholtz a5a8b83
add IDB_RECOVER_CONNECTION event to lexicon
mnholtz 491128e
add IDB_UNRESPONSIVE_BANNER to lexicon
mnholtz 0555593
tweak description
mnholtz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer note that IDBReclaimQuota and IDBRecoverConnection events have never been reported to Mixpanel before; you can verify this by the lack of entries for either events in the lexicon right now (Mixpanel with automatically make empty lexicon entries for new events, but only once the event has been reported to mixpanel for the first time)
Not sure what the action item is here; just wanted to give a heads up for those that are invested in IDB issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fungairino FYI