#9151 Add mod runtime and IDB error events to lexicon #9345
+48
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnholtz
commented
Oct 24, 2024
| "Reported when a user clicks the 'Recover Connection' button on the IndexedDB (IDB) error display in the Extension " + | ||
| "Console when the user gets a 'Error connecting to local database' error.", | ||
| tags: [LexiconTags.EXTENSION_CONSOLE], | ||
| }, |
There was a problem hiding this comment.
Reviewer note that IDBReclaimQuota and IDBRecoverConnection events have never been reported to Mixpanel before; you can verify this by the lack of entries for either events in the lexicon right now (Mixpanel with automatically make empty lexicon entries for new events, but only once the event has been reported to mixpanel for the first time)
Not sure what the action item is here; just wanted to give a heads up for those that are invested in IDB issues
twschiller
approved these changes
Oct 25, 2024
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?