-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9151 Add mod runtime and IDB error events to lexicon #9345
base: main
Are you sure you want to change the base?
Conversation
"Reported when a user clicks the 'Recover Connection' button on the IndexedDB (IDB) error display in the Extension " + | ||
"Console when the user gets a 'Error connecting to local database' error.", | ||
tags: [LexiconTags.EXTENSION_CONSOLE], | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer note that IDBReclaimQuota and IDBRecoverConnection events have never been reported to Mixpanel before; you can verify this by the lack of entries for either events in the lexicon right now (Mixpanel with automatically make empty lexicon entries for new events, but only once the event has been reported to mixpanel for the first time)
Not sure what the action item is here; just wanted to give a heads up for those that are invested in IDB issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fungairino FYI
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?