Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8864: fix select similar in selection tool #8877

Merged
merged 3 commits into from
Jul 18, 2024
Merged

#8864: fix select similar in selection tool #8877

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce146d5
#8864: fix select similar
twschiller Jul 18, 2024
672db09
Consistency
twschiller Jul 18, 2024
cae80e7
Fix comment
twschiller Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/components/selectionToolPopover/SelectionToolPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,24 @@ const SelectionToolPopover: React.FC<{
</>
)}

<Button size="sm" variant="info" onClick={onCancel}>
<Button
size="sm"
variant="info"
onClick={() => {
// Avoid passing event to onCancel method in case the provided method takes an optional argument
onCancel();
}}
>
Cancel
</Button>
<Button
className="info ml-1"
size="sm"
variant="primary"
onClick={onDone}
onClick={() => {
// Avoid passing event to onDone method in case the provided method takes an optional argument
onDone();
}}
>
Done
</Button>
Expand Down
Loading