Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8864: fix select similar in selection tool #8877

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Jul 18, 2024

What does this PR do?

Future Work

For more information on our expectations for the PR process, see the
code review principles doc

@twschiller twschiller added the bug Something isn't working label Jul 18, 2024
@twschiller twschiller self-assigned this Jul 18, 2024
@twschiller twschiller added this to the 2.0.6 milestone Jul 18, 2024
@twschiller twschiller changed the title #8864: fix select similar #8864: fix select similar in selection tool Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.37%. Comparing base (8318d74) to head (cae80e7).
Report is 98 commits behind head on main.

Files Patch % Lines
...ents/selectionToolPopover/SelectionToolPopover.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8877      +/-   ##
==========================================
+ Coverage   74.24%   74.37%   +0.13%     
==========================================
  Files        1332     1340       +8     
  Lines       40817    41202     +385     
  Branches     7634     7710      +76     
==========================================
+ Hits        30306    30646     +340     
- Misses      10511    10556      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 18, 2024

Playwright test results

passed  108 passed
skipped  4 skipped

Details

report  Open report ↗︎
stats  112 tests across 37 suites
duration  7 minutes, 42 seconds
commit  cae80e7
info  For more information on how to debug and view this report, see our readme

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
edge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller merged commit 5a5ea5c into main Jul 18, 2024
25 checks passed
@twschiller twschiller deleted the feature/8864-select-similar branch July 18, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants