Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4887: move document builder to pageEditor directory #8629

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Jun 16, 2024

What does this PR do?

Reviewer Notes

Future Work

  • Adjust cross-boundary imports to allow cross-boundary imports of the "render" directory of the document builder

Checklist

  • Add jest or playwright tests and/or storybook stories: N/A
  • Designate a primary reviewer: @mnholtz

@twschiller twschiller changed the title #4887: move document builder to pageEditor directory #4887: move document builder to pageEditor directory Jun 16, 2024
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.66%. Comparing base (18c5348) to head (beb7a51).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8629      +/-   ##
==========================================
+ Coverage   73.63%   73.66%   +0.02%     
==========================================
  Files        1344     1344              
  Lines       41544    41575      +31     
  Branches     7767     7778      +11     
==========================================
+ Hits        30592    30625      +33     
+ Misses      10952    10950       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Playwright test results

passed  73 passed
skipped  2 skipped

Details

report  Open report ↗︎
stats  75 tests across 25 suites
duration  10 minutes, 34 seconds
commit  beb7a51

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller merged commit 9115a32 into main Jun 17, 2024
22 checks passed
@twschiller twschiller deleted the feature/4887-document-builder branch June 17, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants