Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4887: move add brick modal to pageEditor and rename #8628

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Jun 16, 2024

What does this PR do?

Reviewer Notes

  • UrlPatternWidget and other Page Editor-specific widgets have already been moved to the pageEditor directory
  • Other modals (e.g., the save modal) reside in the Page Editor subdirectory they're rendered from (e.g., the sidebar subdirectory). We might consider putting the addBrickModal in the tabs/editTab subdirectory
  • The old "BrickModal" still resides in components and is used for selecting an integrations when adding a Local Integration Configuration:
    function BrickModal<T extends Metadata>({

Future Work

  • Move the documentBuilder to the pageEditor directory. The documentBuilder/render directory is imported in sidebar and other contexts where documents are shown. So there will still be cross-boundary imports. (If/when we fix the rule, the "render" directory would be the exception): #4887: move document builder to pageEditor directory #8629

Checklist

  • Add jest or playwright tests and/or storybook stories: N/A
  • Designate a primary reviewer: @BLoe

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

Attention: Patch coverage is 90.81633% with 9 lines in your changes missing coverage. Please review.

Project coverage is 73.65%. Comparing base (18c5348) to head (ce48b2d).
Report is 25 commits behind head on main.

Files Patch % Lines
.../pageEditor/modals/addBrickModal/AddBrickModal.tsx 83.67% 8 Missing ⚠️
...rc/pageEditor/modals/addBrickModal/BrickDetail.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8628      +/-   ##
==========================================
+ Coverage   73.63%   73.65%   +0.01%     
==========================================
  Files        1344     1344              
  Lines       41544    41575      +31     
  Branches     7767     7778      +11     
==========================================
+ Hits        30592    30623      +31     
  Misses      10952    10952              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Playwright test results

passed  72 passed
flaky  1 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  75 tests across 25 suites
duration  11 minutes, 56 seconds
commit  ce48b2d

Flaky tests

chrome › tests/modLifecycle.spec.ts › create, run, package, and update mod

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@twschiller twschiller changed the title #4887: move and rename add brick modal #4887: move add brick modal to pageEditor and rename Jun 16, 2024
@twschiller twschiller added this to the 2.0.3 milestone Jun 16, 2024
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller merged commit ea4f702 into main Jun 17, 2024
22 checks passed
@twschiller twschiller deleted the feature/4887-add-brick-modal branch June 17, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants