#4887: move add brick modal to pageEditor
and rename
#8628
Merged
+213
−211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
pageEditor/modals
directoryaddBlockModal
toaddBrickModal
block
tobrick
within the directoryReviewer Notes
UrlPatternWidget
and other Page Editor-specific widgets have already been moved to the pageEditor directorysidebar
subdirectory). We might consider putting theaddBrickModal
in thetabs/editTab
subdirectorypixiebrix-extension/src/components/brickModalNoTags/BrickModal.tsx
Line 299 in ce48b2d
Future Work
documentBuilder
to the pageEditor directory. ThedocumentBuilder/render
directory is imported in sidebar and other contexts where documents are shown. So there will still be cross-boundary imports. (If/when we fix the rule, the "render" directory would be the exception): #4887: move document builder topageEditor
directory #8629Checklist