Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for standalone mod components - Slice 2 - Remove standalone mod component api calls #8980

Closed
BLoe opened this issue Aug 7, 2024 · 0 comments · Fixed by #9006
Closed

Drop support for standalone mod components - Slice 2 - Remove standalone mod component api calls #8980

BLoe opened this issue Aug 7, 2024 · 0 comments · Fixed by #9006
Assignees
@BLoe
Labels
developer experience

Comments

@BLoe
Copy link
Contributor

BLoe commented Aug 7, 2024 •
edited
Loading

See here: https://www.notion.so/pixiebrix/Drop-support-for-standalone-mod-components-f7f3b59fc3474e45955a7b7d46baf333#1e86868c7fad4c45b66620fc30150354

In this issue, we'll drop the RTK Query endpoints for standalone mod components, and clean up all related code at the call sites.

Note: We are also running a migration on the back end to deprecate these endpoints.

Follows on from #8979
@BLoe BLoe self-assigned this Aug 7, 2024
@BLoe BLoe mentioned this issue Aug 7, 2024
Closed
5 tasks
@BLoe BLoe changed the title Drop support for standalone mod components - Slice 2 - Cleanup standalone component code Drop support for standalone mod components - Slice 2 - Remove standalone mod component api calls Aug 12, 2024
This was referenced Aug 12, 2024
Closed
Merged
Closed
BLoe added a commit that referenced this issue Aug 14, 2024
@BLoe
#8980 Remove standalone mod api calls (#9006)
0816255 
* remove standalone mod components and dependencies/uses

* fix test

* fix test name

* fix snapshots

* fix dead code and re-implement test with mod definition

* fix imports

* update playwright test

* improve function comment

* update comment again

---------

Co-authored-by: Ben Loe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BLoe BLoe

Labels
developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#8980 Remove standalone mod api calls pixiebrix/pixiebrix-extension
2 participants
@twschiller @BLoe