Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8980 Remove standalone mod api calls #9006

Merged
merged 9 commits into from
Aug 14, 2024

Conversation

BLoe
Copy link
Contributor

@BLoe BLoe commented Aug 13, 2024

What does this PR do?

For more information on our expectations for the PR process, see the
code review principles doc

Copy link

github-actions bot commented Aug 13, 2024

Playwright test results

passed  121 passed
flaky  3 flaky
skipped  6 skipped

Details

report  Open report ↗︎
stats  130 tests across 44 suites
duration  40 minutes, 14 seconds
commit  8c99124
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
chrome › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
chrome › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8154: can insert at cursor after opening sidebar from selection menu
msedge › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8154: can insert at cursor after opening sidebar from selection menu

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.22%. Comparing base (8318d74) to head (8c99124).
Report is 177 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9006      +/-   ##
==========================================
- Coverage   74.24%   74.22%   -0.03%     
==========================================
  Files        1332     1347      +15     
  Lines       40817    41684     +867     
  Branches     7634     7792     +158     
==========================================
+ Hits        30306    30938     +632     
- Misses      10511    10746     +235     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

{ modId },
{
// Force-refetch the latest data for mod definition before activation. (Because the user might
// have already had the Extension Console open when the mod was updated.)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

/**
* Optionally force a specific mod component id to be assigned to the mod. If the mod definition has multiple
* components, an error will be thrown.
* @since 2.0.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, @BLoe this looks like the code you were talking about that was introduced to make it easy to ease off standalone mod components? Was thinking to myself that I didn't recognize the forceModComponentId

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that was introduced recently

src/mods/useMods.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@mnholtz mnholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with deferring to others on the conversation regarding removing the useMods tests, with a follow-up ticket to test that hook

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@BLoe
Copy link
Contributor Author

BLoe commented Aug 14, 2024

follow-up ticket to test that hook

@mnholtz There is so much change coming soon to the mods page and this hook, that I didn't think it would be worth writing new tests for what is essentially a "transient" state in the code base. Once the Mods Page changes settle down, I plan on going back through and adding test coverage everywhere that it makes sense at that point.

@BLoe BLoe merged commit 0816255 into main Aug 14, 2024
22 checks passed
@BLoe BLoe deleted the feature/8980-remove-standalone-mod-api-calls branch August 14, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for standalone mod components - Slice 2 - Remove standalone mod component api calls
4 participants