Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for standalone mod components - Slice 4 - Refactor _recipe mod component property #9003

Closed
BLoe opened this issue Aug 12, 2024 · 1 comment
Assignees

Comments

@BLoe
Copy link
Contributor

BLoe commented Aug 12, 2024

See here: https://www.notion.so/pixiebrix/Drop-support-for-standalone-mod-components-f7f3b59fc3474e45955a7b7d46baf333#1e86868c7fad4c45b66620fc30150354

  • Change the signature of the ModComponentBase._recipe: ModMetadata | undefined field to be modMetadata: ModMetadata
  • Migrate the types in redux-persist (It's now decoupled from the api, so this is ok)
  • Clean up all the call sites and collapse all code that is currently handling _recipe == null cases

Follows on from #8979 & #8980 & #9007

@BLoe BLoe self-assigned this Aug 12, 2024
@BLoe BLoe changed the title Drop support for standalone mod components - Slice 3 - Cleanup standalone component code Drop support for standalone mod components - Slice 4 - Refactor _recipe mod component property Aug 13, 2024
@twschiller
Copy link
Contributor

Closing in favor of refactoring in next phase: https://pixiebrix.slack.com/archives/C02RAMRDF0R/p1724350221764719

@twschiller twschiller closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants