Skip to content

Add play environment introduction blog #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 12, 2022
Merged

Add play environment introduction blog #3448

merged 9 commits into from
Apr 12, 2022

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Mar 27, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot pipecd-bot requested a review from knanao March 27, 2022 11:19
@pipecd-bot pipecd-bot requested a review from nghialv March 27, 2022 11:19
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Mar 27, 2022

COVERAGE

Code coverage for golang is 35.11%. This pull request does not change code coverage.

knanao
knanao reviewed Mar 28, 2022
View reviewed changes
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Mar 28, 2022

COVERAGE

Code coverage for golang is 35.11%. This pull request does not change code coverage.

@knanao
Copy link
Member

knanao commented Mar 29, 2022

Nice catch!
/lgtm

@nghialv
Copy link
Member

nghialv commented Mar 29, 2022

/hold

Hold this until the plan-preview on the examples repository gets ready.

@nghialv
Copy link
Member

nghialv commented Mar 29, 2022

/hold

nghialv
nghialv reviewed Apr 7, 2022
View reviewed changes
@pipecd-bot pipecd-bot removed the lgtm label Apr 8, 2022
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Apr 8, 2022

COVERAGE

Code coverage for golang is 35.11%. This pull request does not change code coverage.

nghialv
nghialv reviewed Apr 8, 2022
View reviewed changes
nghialv
nghialv reviewed Apr 8, 2022
View reviewed changes
nghialv
nghialv reviewed Apr 8, 2022
View reviewed changes
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Apr 8, 2022

COVERAGE

Code coverage for golang is 35.11%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Apr 8, 2022

Well done. Love it.
/approve

@nghialv
Copy link
Member

nghialv commented Apr 8, 2022

/approve cancel

nghialv
nghialv reviewed Apr 8, 2022
View reviewed changes
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Apr 8, 2022

COVERAGE

Code coverage for golang is 35.11%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member Author

khanhtc1202 commented Apr 12, 2022

/hold cancel

khanhtc1202
khanhtc1202 commented Apr 12, 2022
View reviewed changes
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Apr 12, 2022

COVERAGE

Code coverage for golang is 35.11%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Apr 12, 2022

/lgtm

knanao
knanao reviewed Apr 12, 2022
View reviewed changes
Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally 🙌
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Apr 12, 2022

APPROVE

This pull request is APPROVED by knanao.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 6bf5e6c into master Apr 12, 2022
@pipecd-bot pipecd-bot deleted the add-blog-about-play branch April 12, 2022 03:46
@pipecd-bot pipecd-bot mentioned this pull request Apr 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nghialv nghialv nghialv left review comments

+1 more reviewer

@knanao knanao knanao left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved area/docs area/site lgtm release-note-none size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@khanhtc1202 @pipecd-bot @knanao @nghialv