Skip to content

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Apr 14, 2022

What this PR does / why we need it:

Make the Terraform module version field optional

Which issue(s) this PR fixes:

Fixes #3531

Does this PR introduce a user-facing change?:

Fix error unable to plan deployment of kind Terraform in case of missing module version argument

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.69%. This pull request does not change code coverage.

Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
/lgtm

@nghialv
Copy link
Member

nghialv commented Apr 14, 2022

Maybe we have to get rid of this validation as well.
https://github.com/pipe-cd/pipecd/blob/master/pkg/model/common.proto#L88

@khanhtc1202
Copy link
Member Author

Maybe we have to get rid of this validation as well. https://github.com/pipe-cd/pipecd/blob/master/pkg/model/common.proto#L88

Thanks for comment, addressed by 8d061cc

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/model/common.pb.go
--- pkg/model/common.pb.go.orig
+++ pkg/model/common.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.69%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Apr 14, 2022

Nice catch!
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit e2a9465 into master Apr 14, 2022
@pipecd-bot pipecd-bot deleted the optional-version-field branch April 14, 2022 03:58
Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/changelog

@knanao
Copy link
Member

knanao commented Apr 14, 2022

/changelog

@pipecd-bot
Copy link
Collaborator

CHANGELOG

@knanao: Changelog has been generated in response to this comment.

Details

Changelog since v0.27.3

Notable Changes

  • Fix error unable to plan deployment of kind Terraform in case of missing module version argument (#3530)

Internal Changes

  • Define SkipStage gRPC api (#3522)
  • Update docs for piped configuration (#3524)
  • Add play environment introduction blog (#3448)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error planning deployment of Terraform kind in case of missing module version field

5 participants