-
Notifications
You must be signed in to change notification settings - Fork 201
Terraform module version optional #3530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
knanao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
/lgtm
|
Maybe we have to get rid of this validation as well. |
Thanks for comment, addressed by 8d061cc |
|
The following files are not gofmt-ed. By commenting pkg/model/common.pb.go--- pkg/model/common.pb.go.orig
+++ pkg/model/common.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
|
|
Nice catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/changelog
|
/changelog |
|
@knanao: Changelog has been generated in response to this comment. |
What this PR does / why we need it:
Make the Terraform module version field optional
Which issue(s) this PR fixes:
Fixes #3531
Does this PR introduce a user-facing change?: