Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Cleanup #271

Merged
merged 3 commits into from
Aug 7, 2023
Merged

[MISC] Cleanup #271

merged 3 commits into from
Aug 7, 2023

Conversation

benliao1
Copy link
Collaborator

@benliao1 benliao1 commented Aug 7, 2023

This PR simply deletes some old unused code and makes some changes to the .gitattributes file so that the Language statistics on our home page more accurately reflect the contents of our repo. Specifically, this PR does the following:

  • Fixes a bug in the .gitattributes file which previously still included the files in lowcar/lib as Runtime code, and which previously classified some files in lowcar/devices as C code, when they are C++. It also specifically tells Github to highlight Makefile_defs with Makefile syntax
  • Bumps the net_handler/protos submodule to the newest version in that repo, including updates to the run_mode.proto and security.proto
  • Resolves issue [NET_HANDLER] Remove MODE__ESTOP #229 remove the run mode ESTOP from Runtime
  • Fixes the formatting in scripts/test.sh

In lowcar, the RFID and PolarBear devices were deleted, as well as the MFRC22, SevenSeg, and SPI libraries. If new libraries need to be added, they can be downloaded from the Arduino forums and added back into the lowcar library.

- Forced the Makefile_defs file to be highlighted as Makefile
- Changed tabs to spaces in scripts/test.sh
- Fixed formatting error in scripts/format.sh
- Removed mode ESTOP from protos, updated protos submodule (#229)
@benliao1 benliao1 added the code-cleanup Code health fixes/improvements label Aug 7, 2023
@benliao1 benliao1 self-assigned this Aug 7, 2023
Copy link
Contributor

@BrandonWong14 BrandonWong14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good makes sense, the number of files being removed seemed intimidating until I realized most were different parts of very few individual things lol

- Ignore everything in lowcar/lib for language stats
- Ensure that .h files in lowcar/devices classified as C++
@benliao1 benliao1 merged commit 8fa2e4d into master Aug 7, 2023
1 check passed
@benliao1 benliao1 deleted the misc-cleanup branch August 7, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-cleanup Code health fixes/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants