Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NET_HANDLER] Remove MODE__ESTOP #229

Closed
benliao1 opened this issue Sep 16, 2021 · 1 comment
Closed

[NET_HANDLER] Remove MODE__ESTOP #229

benliao1 opened this issue Sep 16, 2021 · 1 comment
Assignees
@benliao1
Labels
code-cleanup Code health fixes/improvements good-first-issue Good issues for incoming members oldies For Vincent, Daniel, and/or Ben

Comments

@benliao1
Copy link
Collaborator

The run mode proto still has the ESTOP run mode, which is deprecated. The change should be made in the protos repo and announced to the other software teams for adoption.
@benliao1 benliao1 added the code-cleanup Code health fixes/improvements label Sep 16, 2021
@benliao1 benliao1 self-assigned this Sep 16, 2021
@benliao1 benliao1 added the good-first-issue Good issues for incoming members label Sep 22, 2021
@benliao1 benliao1 removed their assignment Sep 24, 2021
@edtruong8 edtruong8 self-assigned this Feb 3, 2022
@Marcoss28 Marcoss28 self-assigned this Feb 10, 2022
@benliao1 benliao1 added the oldies For Vincent, Daniel, and/or Ben label Jul 21, 2022
@benliao1 benliao1 assigned benliao1 and unassigned Marcoss28 and edtruong8 Jun 22, 2023
benliao1 added a commit that referenced this issue Aug 1, 2023
@benliao1
[MISC] Miscellaneous cleanup changes
dc93988 
- Forced the Makefile_defs file to be highlighted as Makefile
- Changed tabs to spaces in scripts/test.sh
- Fixed formatting error in scripts/format.sh
- Removed mode ESTOP from protos, updated protos submodule (#229)
@benliao1 benliao1 mentioned this issue Aug 7, 2023
Merged
@benliao1
Copy link
Collaborator Author

benliao1 commented Aug 7, 2023

Closed by #271 . Closing now.

@benliao1 benliao1 closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benliao1 benliao1

Labels
code-cleanup Code health fixes/improvements good-first-issue Good issues for incoming members oldies For Vincent, Daniel, and/or Ben
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benliao1 @Marcoss28 @edtruong8