Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): use admin statement to query async ddl status #11535

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Aug 28, 2024

What problem does this PR solve?

Issue Number: close #11521

What is changed and how it works?

  • Use admin statement to query async ddl status since the original querying operation has performance issue.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Test result in scenarios with a large number of historical DDLs:
    image

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2024
@CharlesCheung96
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 6 lines in your changes missing coverage. Please review.

Project coverage is 57.4476%. Comparing base (6f697c4) to head (ee68539).
Report is 2 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.1819% <84.2105%> (+0.0004%) ⬆️
dm 51.0293% <ø> (+0.0080%) ⬆️
engine 63.3879% <ø> (ø)
Flag Coverage Δ
unit 57.4476% <84.2105%> (+0.0046%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11535        +/-   ##
================================================
+ Coverage   57.4429%   57.4476%   +0.0046%     
================================================
  Files           851        851                
  Lines        126421     126463        +42     
================================================
+ Hits          72620      72650        +30     
- Misses        48394      48404        +10     
- Partials       5407       5409         +2     

@CharlesCheung96 CharlesCheung96 force-pushed the fix-async-ddl branch 2 times, most recently from 61432d5 to 2877a38 Compare August 30, 2024 05:25
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2024
@3AceShowHand
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2024
@ti-chi-bot ti-chi-bot bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 2, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-02 06:31:13.582060959 +0000 UTC m=+253198.100113876: ☑️ agreed by 3AceShowHand.
  • 2024-09-02 09:04:36.367377096 +0000 UTC m=+262400.885430020: ☑️ agreed by hongyunyan.

Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3AceShowHand
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit b999807 into pingcap:master Sep 2, 2024
27 of 28 checks passed
@CharlesCheung96 CharlesCheung96 added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Sep 2, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 2, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11549.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #11550.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11551.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 2, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #11552.

wk989898 pushed a commit to wk989898/tiflow that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create table ddl executed too slow when using tidb as the downstream sink
6 participants