Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/p2p(ticdc): fix default p2p config #11182

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented May 27, 2024

What problem does this PR solve?

Issue Number: close #11215

What is changed and how it works?

Increase the p2p configuration to cache more messages

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Deploy ticdc cluster(7 nodes, 8c16g, replicating 150k tables, 1 changefeed) with the following configuration:

[debug.scheduler]
add-table-batch-size = 1000
  1. Before this pr:
    The scheduling task took up to 3 hours to complete:
    image
  2. This pr:
    The dispatch task was completed in 10 minutes:
    image

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

`None`.

Copy link
Contributor

ti-chi-bot bot commented May 27, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2024
@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 28, 2024
@CharlesCheung96
Copy link
Contributor Author

/test all

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 58.2007%. Comparing base (cf7055d) to head (cee8901).
Report is 24 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 62.4286% <40.0000%> (∅)
dm 51.2560% <ø> (+0.0458%) ⬆️
engine 63.4232% <ø> (+0.0141%) ⬆️
Flag Coverage Δ
unit 58.2007% <40.0000%> (+4.2818%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11182        +/-   ##
================================================
+ Coverage   53.9188%   58.2007%   +4.2818%     
================================================
  Files           403        850       +447     
  Lines         63781     127952     +64171     
================================================
+ Hits          34390      74469     +40079     
- Misses        26694      48062     +21368     
- Partials       2697       5421      +2724     

@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review May 29, 2024 12:11
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels May 29, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 13, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [asddongmen,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 13, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-13 02:04:06.475714491 +0000 UTC m=+603000.529026411: ☑️ agreed by hongyunyan.
  • 2024-06-13 02:08:41.101131625 +0000 UTC m=+603275.154443548: ☑️ agreed by asddongmen.

@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 999d393 into pingcap:master Jun 13, 2024
28 checks passed
@CharlesCheung96 CharlesCheung96 added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jun 13, 2024
@CharlesCheung96 CharlesCheung96 added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jun 13, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #11306.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 13, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 13, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11307.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11308.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #11309.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 13, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #11310.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p2p may discard scheduling messages when synchronize 150k tables in single changefeed
4 participants