i18n(ja): fix requirement-strength inversions (should mistranslated as must) - #23731
Conversation
…s must) 10 sites across 7 files rendered English "should" (a recommendation) as Japanese する必要があります / でなければなりません (a mandatory requirement), inflating advisory guidance into a hard requirement. Changed each to お勧めします / 推奨します / 望まれます to match the EN source's actual modal strength.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
|
Warning Review limit reachedNext included review available in 48 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (6)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughJapanese documentation guidance was reworded across TiDB, BR, DM, TiFlash, and TiKV. Mandatory expressions now use recommendation wording. No code, API, configuration value, or functional behavior changed. ChangesRecommendation wording updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change corrects Japanese documentation from mandatory to advisory wording while preserving the documented technical guidance and values. No current merge-readiness risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the 10 wording corrections, identifies all 7 affected files and sections, states the applicable Japanese TiDB 8.5 version, and records AI involvement. The reference-link fields are blank, but the required information is otherwise complete. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (7 skipped: 7 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
望まれます read as vague/passive for technical documentation; べきです is the more idiomatic technical-doc rendering of English "should" here.
Use the more standard technical-doc term 推奨します instead of お勧めします for consistency across this fix's new insertions.
"保証することを推奨します" ("recommend guaranteeing") reads as
contradictory in Japanese since 保証 (absolute) and 推奨 (advisory)
clash. Rephrase as "アクセスできるようにすることを推奨します" to keep
the advisory tone consistent throughout.
Revert the previous paraphrase; translate the EN source literally
("You should guarantee that...") and express the should-tier modal
strength via 推奨されます instead of dropping the word 保証.
Switch from passive 推奨されます to active 推奨します, matching the other should-tier fixes in this PR.
qiancai
added
translation/no-need
[LGTM Timeline notifier]Timeline:
|
2 participants
What is changed, added or deleted? (Required)
Fix 10 requirement-strength inversions across 7 files, where English "should" (an advisory recommendation) was mistranslated as Japanese
する必要があります/でなければなりません(a mandatory requirement), inflating a recommendation into a hard requirement:br/br-snapshot-guide.md— "should be tested in actual environments" → テストする必要があります (should be テストすることをお勧めします)br/use-br-command-line-tool.md— "you should tune ... instead" → 調整する必要があります (should be 調整することをお勧めします)br/br-compact-log-backup.md— "should match the output from the log status command" → 一致する必要があります (should be 一致させることを推奨します)dm/dm-best-practices.md— "you should reserve some work nodes as standby nodes" → 確保する必要があります (should be 確保することをお勧めします)best-practices/tidb-best-practices.md— "the number of indexes should be proper" → 適切でなければなりません (should be 適切であることが望まれます)tikv-configuration-file.md(max-bytes-per-sec) — "should be set to the disk's optimal I/O bandwidth" → 設定する必要があります (should be 設定することをお勧めします)tikv-configuration-file.md(max-bytes-for-level-base) — "should be write-buffer-size * 4" → にする必要があります (should be にすることをお勧めします)tikv-configuration-file.md(renew-interval) — "you should also consider the load of PD" → 考慮する必要があります (should be 考慮することをお勧めします)tiflash/tiflash-configuration.md(advertise-addr) — "You should guarantee that other nodes can access" → 保証する必要があります (should be 保証することをお勧めします)tiflash/tiflash-configuration.md(advertise-status-addr) — same pattern as aboveAll verified against the English source on
release-8.5for the same file/section before fixing.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit