Skip to content

i18n(ja): fix dropped particles, misplaced clauses, and broken parentheses in release notes - #23709

Open
yahonda wants to merge 7 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-release-notes-deep-review
Open

i18n(ja): fix dropped particles, misplaced clauses, and broken parentheses in release notes#23709
yahonda wants to merge 7 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-release-notes-deep-review

Conversation

@yahonda

@yahonda yahonda commented Sep 2, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Fixes several machine-translation defects found during a line-by-line review of release-4.0.0-beta.md, release-4.0.0-beta.1.md, and release-4.0-ga.md, plus 9 files flagged by a full-width-parenthesis balance check (release-2.0-rc.3.md, release-3.0.6.md, release-6.3.0.md, release-6.5.0.md, release-7.1.0.md, release-7.1.3.md, release-7.5.4.md, release-8.4.0.md, release-8.5.0.md):

  • Dropped particles (を/が/の) before/after noun-modifying verbs
  • Misplaced/orphaned clause fragments drifted away from the phrase they modify
  • A mistranslation ("normal" read as geometric "surface normal" instead of "usual/regular")
  • Word-order swaps not matching a correct duplicate of the same bullet elsewhere in the same file
  • Unclosed or stray full-width parentheses, in one case fully reconstructing a garbled/scrambled sentence to match the English source

This is a subset of a broader review pass; overlapping fixes already covered by #23704 and #23706 were excluded here to avoid duplicating those PRs.

Which TiDB version(s) do your changes apply to? (Required)

  • v8.5 (LTS)

Do your changes match one of the following descriptions? (Required)

  • Delete docs
  • Add docs for a new feature
  • Improve docs quality on top of what already exists
  • Docs for a TiDB Cloud feature (this feature is not in TiDB self-managed)
  • Documentation for open source RFC

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Corrected punctuation, parentheses, grammar, and formatting across release notes for TiDB versions 2.0 through 8.5.
    • Improved Japanese wording and readability in descriptions of features, improvements, and bug fixes.
    • Corrected technical references, code formatting, terminology, and inline code presentation.
    • Reordered selected links and bullet points for clearer presentation.
    • Clarified release documentation without changing product functionality or the documented content of issues.

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: a729ae21-6e46-476a-be26-c3de01ad66a4

📥 Commits

Reviewing files that changed from the base of the PR and between 5571e3b and 79eb049.

📒 Files selected for processing (1)
  • releases/release-4.0.0-beta.md

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The release notes receive typographical, punctuation, Japanese wording, inline-formatting, and bullet-structure corrections. No product functionality or public declarations change.

Changes

Release notes editorial corrections

Layer / File(s) Summary
Punctuation and inline formatting corrections
releases/release-2.0-rc.3.md, releases/release-3.0.6.md, releases/release-6.3.0.md, releases/release-6.5.0.md, releases/release-7.1.0.md, releases/release-7.1.3.md, releases/release-8.4.0.md
Closing punctuation, parentheses, inline code delimiters, and contributor-link formatting are corrected.
Japanese wording and list corrections
releases/release-4.0-ga.md, releases/release-4.0.0-beta.1.md, releases/release-4.0.0-beta.md, releases/release-7.5.4.md, releases/release-8.5.0.md
Japanese grammar, terminology, front matter, sentence structure, and bullet-list organization are corrected without changing feature content.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 79eb0

This updates Japanese release-note wording and formatting only, without changing product behavior. The corrections are ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the changes and identifies the affected files, but it selects only v8.5 even though the changes affect release notes from TiDB 2.0 through 8.5. It also omits the required rela… Specify all affected TiDB versions or explain the repository's version-selection rule for historical release notes. Add the related PR or file links section, including references to PRs #23704 and #23706, and complete the remaining applicab…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main changes: Japanese translation corrections and broken-parenthesis fixes in release notes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the changes and identifies the affected files, but it selects only v8.5 even though the changes affect release notes from TiDB 2.0 through 8.5. It also omits the required related PR or file links section and does not use the complete template checklist.

Resolution

Specify all affected TiDB versions or explain the repository's version-selection rule for historical release notes. Add the related PR or file links section, including references to PRs #23704 and #23706, and complete the remaining applicable template sections.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oreoxmt for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2026
@yahonda
yahonda marked this pull request as ready for review September 2, 2026 07:58
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 425ff1b3-ade6-4d79-92b9-54e67b5db972

📥 Commits

Reviewing files that changed from the base of the PR and between 23d5ab9 and 94bd24a.

📒 Files selected for processing (12)
  • releases/release-2.0-rc.3.md
  • releases/release-3.0.6.md
  • releases/release-4.0-ga.md
  • releases/release-4.0.0-beta.1.md
  • releases/release-4.0.0-beta.md
  • releases/release-6.3.0.md
  • releases/release-6.5.0.md
  • releases/release-7.1.0.md
  • releases/release-7.1.3.md
  • releases/release-7.5.4.md
  • releases/release-8.4.0.md
  • releases/release-8.5.0.md

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.

Comment thread releases/release-2.0-rc.3.md Outdated
Comment thread releases/release-4.0-ga.md Outdated
Comment thread releases/release-4.0.0-beta.md Outdated
@yahonda
yahonda marked this pull request as draft September 2, 2026 08:28
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
@yahonda
yahonda marked this pull request as ready for review September 3, 2026 00:45
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2026
yahonda added a commit to yahonda/docs that referenced this pull request Sep 3, 2026
@yahonda
yahonda force-pushed the fix-ja-release-notes-deep-review branch from 6e58047 to 79eb049 Compare September 3, 2026 02:08
yahonda added a commit to yahonda/docs that referenced this pull request Sep 3, 2026
@yahonda
yahonda marked this pull request as draft September 3, 2026 02:13
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2026
@yahonda
yahonda marked this pull request as ready for review September 3, 2026 02:19
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 3, 2026
yahonda and others added 7 commits September 3, 2026 13:40
…heses in release notes

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…23706

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@yahonda
yahonda force-pushed the fix-ja-release-notes-deep-review branch from 7ef71c4 to 6b86e95 Compare September 3, 2026 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants