Skip to content

i18n(ja): fix swapped word order across the corpus - #23698

Open
yahonda wants to merge 4 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-scramble-sweep
Open

i18n(ja): fix swapped word order across the corpus#23698
yahonda wants to merge 4 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-scramble-sweep

Conversation

@yahonda

@yahonda yahonda commented Sep 2, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Corpus-wide sweep for a recurring defect class: a sentence contains two backtick-quoted identifiers (config items, table/column names, SQL keywords, error strings) whose relative positions got swapped in the Japanese translation, reversing which term modifies which (e.g. "the DELETE privilege on user" becoming "the user privilege on DELETE").

Fixed 42 occurrences across 17 files:

  • tidb-cloud/get-started-with-cli.md: reversed recommendation to use ticloud instead of tiup cloud (should be the other way around per EN), plus a stray MT-artifact brace
  • 41 occurrences across 16 releases/*.md files (release-5.1.0.md through release-8.5.2.md)

Each fix was verified against the corresponding EN source in release-8.5, including cross-checking sibling release files that backport the same PR/issue (several already had the correct order, confirming these were isolated translation slips rather than systemic).

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Corrected Japanese wording throughout TiDB 5.1–8.5.2 release notes, including descriptions of features, bug fixes, commands, settings, errors, and compatibility behavior.
    • Corrected TiDB Cloud CLI Quick Start instructions for TiUP usage, including the proper tiup cloud command and removal of an extraneous character.

@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign overvenus for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 15 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 94e8981a-0939-4390-bc56-c1044e0e8737

📥 Commits

Reviewing files that changed from the base of the PR and between 3712c30 and 6e6f464.

📒 Files selected for processing (3)
  • releases/release-5.2.0.md
  • releases/release-5.2.4.md
  • releases/release-8.5.1.md

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: c8ce78f9-560e-4760-9cbf-a20fed4f03e9

📥 Commits

Reviewing files that changed from the base of the PR and between a82e814 and 3712c30.

📒 Files selected for processing (17)
  • releases/release-5.1.0.md
  • releases/release-5.1.5.md
  • releases/release-5.2.0.md
  • releases/release-5.2.4.md
  • releases/release-6.3.0.md
  • releases/release-6.4.0.md
  • releases/release-7.3.0.md
  • releases/release-7.5.0.md
  • releases/release-7.6.0.md
  • releases/release-8.0.0.md
  • releases/release-8.2.0.md
  • releases/release-8.3.0.md
  • releases/release-8.4.0.md
  • releases/release-8.5.0.md
  • releases/release-8.5.1.md
  • releases/release-8.5.2.md
  • tidb-cloud/get-started-with-cli.md

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The diff corrects Japanese wording in TiDB release notes from versions 5.1.0 through 8.5.2 and in TiDB Cloud CLI documentation. The changes clarify technical term relationships, command attribution, error descriptions, and sentence structure.

Changes

Japanese documentation corrections

Layer / File(s) Summary
TiDB 5.x and 6.x release-note corrections
releases/release-5.1.0.md, releases/release-5.1.5.md, releases/release-5.2.0.md, releases/release-5.2.4.md, releases/release-6.3.0.md, releases/release-6.4.0.md
Corrects command attribution, SQL error descriptions, function behavior, thread-pool movement, data-type wording, and permission requirements.
TiDB 7.x release-note corrections
releases/release-7.3.0.md, releases/release-7.5.0.md, releases/release-7.6.0.md
Corrects BR restore, GROUP_CONCAT, client-go, systemd, TiCDC, CTE, partition, LIKE, ADMIN CHECK, and nested UNION descriptions.
TiDB 8.0.0–8.3.0 release-note corrections
releases/release-8.0.0.md, releases/release-8.2.0.md, releases/release-8.3.0.md
Corrects Japanese word order and technical relationships across TiDB, TiCDC, TiDB Lightning, PD, and SQL-related entries.
TiDB 8.4.0–8.5.2 and CLI corrections
releases/release-8.4.0.md, releases/release-8.5.0.md, releases/release-8.5.1.md, releases/release-8.5.2.md, tidb-cloud/get-started-with-cli.md
Corrects descriptions for SUB_PART, IMPORT INTO, query ordering, TiFlash, BR, DM, and the tiup cloud command.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: 🔵 Low · up to 3712c

This change improves Japanese release-note and CLI wording, but three release-note entries still contain punctuation, terminology, or code-formatting defects that can confuse readers. The impact is limited to documentation and is suitable for prompt owner follow-up.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary change: correcting swapped word order across the Japanese documentation corpus.
Description check ✅ Passed The description explains the changes, affected files, validation method, target version, AI involvement, and applicable checklist items. The reference-link fields are blank, but they are non-critical …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the changes, affected files, validation method, target version, AI involvement, and applicable checklist items. The reference-link fields are blank, but they are non-critical because the description provides sufficient context.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (17 skipped: 17 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yahonda
yahonda marked this pull request as ready for review September 2, 2026 05:29
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 15f5254d-f313-4e77-b43e-7dde2b4b58ba

📥 Commits

Reviewing files that changed from the base of the PR and between 23d5ab9 and ec5d538.

📒 Files selected for processing (17)
  • releases/release-5.1.0.md
  • releases/release-5.1.5.md
  • releases/release-5.2.0.md
  • releases/release-5.2.4.md
  • releases/release-6.3.0.md
  • releases/release-6.4.0.md
  • releases/release-7.3.0.md
  • releases/release-7.5.0.md
  • releases/release-7.6.0.md
  • releases/release-8.0.0.md
  • releases/release-8.2.0.md
  • releases/release-8.3.0.md
  • releases/release-8.4.0.md
  • releases/release-8.5.0.md
  • releases/release-8.5.1.md
  • releases/release-8.5.2.md
  • tidb-cloud/get-started-with-cli.md

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Comment thread releases/release-5.2.0.md Outdated
Comment thread releases/release-5.2.4.md Outdated
Comment thread releases/release-8.5.1.md Outdated
@yahonda
yahonda force-pushed the fix-ja-scramble-sweep branch from ec5d538 to 901bb3e Compare September 3, 2026 02:09
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 3, 2026
yahonda and others added 3 commits September 3, 2026 13:26
EN says to use \`tiup cloud\` instead of \`ticloud\` when using TiUP,
but JA had it backwards, and carried a stray MT-artifact brace after
\`ticloud\`.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Corpus-wide sweep of release notes found 41 sentences where two
backtick-quoted identifiers (config items, error strings, SQL
keywords, table/column names) had their positions swapped relative to
EN, reversing which term modifies which. Fixed across 16 files.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The bullet ended with the continuative form 修正し instead of the
sentence-final 修正しました used by every sibling bullet in this list.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@yahonda
yahonda force-pushed the fix-ja-scramble-sweep branch from 901bb3e to 3712c30 Compare September 3, 2026 04:32
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants