Skip to content

fix(reference/stream): HTTP Headers are U+0D U+0A (CRLF) separated #4740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndossche merged 2 commits into from
Jun 22, 2025
Merged

fix(reference/stream): HTTP Headers are U+0D U+0A (CRLF) separated #4740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
037266a
fix(reference/stream): HTTP headers are U+0D U+0A (CR LF) separated
hakre Jun 22, 2025
83ce60c
fix(reference/stream): example code php5.4 array syntax
hakre Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions language/context/http.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,19 +208,19 @@
<?php

$postdata = http_build_query(
array(
[
'var1' => 'some content',
'var2' => 'doh'
)
'var2' => 'doh',
]
);

$opts = array('http' =>
array(
$opts = [
'http' => [
'method' => 'POST',
'header' => 'Content-type: application/x-www-form-urlencoded',
'content' => $postdata
)
);
'content' => $postdata,
]
];

$context = stream_context_create($opts);

Expand All @@ -240,13 +240,13 @@ $result = file_get_contents('http://example.com/submit.php', false, $context);

$url = "http://www.example.org/header.php";

$opts = array('http' =>
array(
'method' => 'GET',
$opts = [
'http' => [
'method' => 'GET',
'max_redirects' => '0',
'ignore_errors' => '1'
)
);
'ignore_errors' => '1',
]
];

$context = stream_context_create($opts);
$stream = fopen($url, 'r', false, $context);
Expand Down
14 changes: 7 additions & 7 deletions reference/filesystem/functions/file-get-contents.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,13 +204,13 @@ string(14) "lle Bjori Ro"
<![CDATA[
<?php
// Create a stream
$opts = array(
'http'=>array(
'method'=>"GET",
'header'=>"Accept-language: en\r\n" .
"Cookie: foo=bar\r\n"
)
);
$opts = [
'http' => [
'method' => "GET",
'header' => "Accept-language: en\r\n" .
"Cookie: foo=bar",
]
];

$context = stream_context_create($opts);

Expand Down
8 changes: 4 additions & 4 deletions reference/libxml/functions/libxml-set-streams-context.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,11 @@
<programlisting role="php" annotations="non-interactive">
<![CDATA[
<?php
$opts = array(
'http' => array(
$opts = [
'http' => [
'user_agent' => 'PHP libxml agent',
)
);
]
];

$context = stream_context_create($opts);
libxml_set_streams_context($context);
Expand Down
5 changes: 3 additions & 2 deletions reference/stream/functions/stream-context-create.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,9 @@
$opts = [
'http' => [
'method' => "GET",
// Use newline \n to separate multiple headers
'header' => "Accept-language: en\nCookie: foo=bar",
// Use CRLF \r\n to separate multiple headers
'header' => "Accept-language: en\r\n" .
"Cookie: foo=bar",
]
];

Expand Down
32 changes: 16 additions & 16 deletions reference/stream/functions/stream-context-get-default.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,24 +76,24 @@
<programlisting role="php">
<![CDATA[
<?php
$default_opts = array(
'http'=>array(
'method'=>"GET",
'header'=>"Accept-language: en\r\n" .
"Cookie: foo=bar",
'proxy'=>"tcp://10.54.1.39:8000"
)
);
$default_opts = [
'http' => [
'method' => "GET",
'header' => "Accept-language: en\r\n" .
"Cookie: foo=bar",
'proxy' => "tcp://10.54.1.39:8000",
]
];


$alternate_opts = array(
'http'=>array(
'method'=>"POST",
'header'=>"Content-type: application/x-www-form-urlencoded\r\n" .
"Content-length: " . strlen("baz=bomb"),
'content'=>"baz=bomb"
)
);
$alternate_opts = [
'http' => [
'method' => "POST",
'header' => "Content-type: application/x-www-form-urlencoded\r\n" .
"Content-length: " . strlen("baz=bomb"),
'content' => "baz=bomb",
]
];

$default = stream_context_get_default($default_opts);
$alternate = stream_context_create($alternate_opts);
Expand Down
16 changes: 8 additions & 8 deletions reference/stream/functions/stream-context-set-default.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,14 @@
<programlisting role="php">
<![CDATA[
<?php
$default_opts = array(
'http'=>array(
'method'=>"GET",
'header'=>"Accept-language: en\r\n" .
"Cookie: foo=bar",
'proxy'=>"tcp://10.54.1.39:8000"
)
);
$default_opts = [
'http' => [
'method' => "GET",
'header' => "Accept-language: en\r\n" .
"Cookie: foo=bar",
'proxy' => "tcp://10.54.1.39:8000",
]
];

$default = stream_context_set_default($default_opts);

Expand Down
14 changes: 8 additions & 6 deletions reference/xmlrpc/functions/xmlrpc-encode-request.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,14 @@
<programlisting role="php">
<![CDATA[
<?php
$request = xmlrpc_encode_request("method", array(1, 2, 3));
$context = stream_context_create(array('http' => array(
'method' => "POST",
'header' => "Content-Type: text/xml",
'content' => $request
)));
$request = xmlrpc_encode_request("method", [1, 2, 3]);
$context = stream_context_create([
'http' => [
'method' => "POST",
'header' => "Content-Type: text/xml",
'content' => $request,
]
]);
$file = file_get_contents("http://www.example.com/xmlrpc", false, $context);
$response = xmlrpc_decode($file);
if ($response && xmlrpc_is_fault($response)) {
Expand Down