fix(reference/stream): HTTP Headers are U+0D U+0A (CRLF) separated #4740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
While double-checking against other examples below reference/stream I've seen that they can benefit from streamlining the improvements of #2956 (PHP 5.4 array syntax). |
correction of the formally wrong comment and place in the example code.
streamlining the example code style on separating multiple headers over multiple lines.
compare Section 4.1 of RFC-2616 etc.
generic-message = start-line
*(message-header CRLF)
CRLF
[ message-body ]
RFC-2616: https://www.rfc-editor.org/rfc/rfc2616#section-4.1
ok: /reference/stream/functions/stream-context-set-default.xml etc.
in reference to 037266a ("fix(reference/stream): HTTP headers are U+0D U+0A (CR LF) separated", 2025-06-22) streamline by 'http' 'header' stream context option.
ndossche
approved these changes
Jun 22, 2025
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Nice catch, and nice improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compare Section 4.1 of RFC-2616 etc.
RFC-2616: https://www.rfc-editor.org/rfc/rfc2616#section-4.1
ok: /reference/stream/functions/stream-context-set-default.xml etc.