Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust documentation to PSR-17 and PSR-18 #310

Merged
merged 1 commit into from
Jan 6, 2024
Merged

adjust documentation to PSR-17 and PSR-18 #310

merged 1 commit into from
Jan 6, 2024

Conversation

dbu
Copy link
Contributor

@dbu dbu commented May 15, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes
Related tickets fixes #309
Documentation -
License MIT

What's in this PR?

deprecate a couple of obsolete PHP-HTTP adapters and clients

remove instructions to install discovery where the clients/adapters require it directly anyways.


The socket client uses the stream extension from PHP, which is integrated into
the core.

This client only implements the PHP-HTTP synchronous interface, which has been
superseded by PSR-18. Use one of the PSR-18 clients instead.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelwurtz @Nyholm i think you 2 mostly worked on the socket client. as it does not implement async and is quite inactive, i think we should deprecate it in favor of using PSR-18 clients.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the package should be updated, or marked abondonded. Not sure what we're waiting for 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wanted to give some time to react for the authors of the package who are part of the php-http group.

but no reaction is also a kind of statement on priorities. i can't promise that i can get to it very soon however, as i have a holidays coming up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbu
Copy link
Contributor Author

dbu commented Jan 6, 2024

i archived all repositories except for socket which seems to still gather some interest. i pinged the person who tried to update it recently if they want to keep maintaining it.

@dbu dbu merged commit 0e99354 into main Jan 6, 2024
2 checks passed
@dbu dbu deleted the message-factory branch January 6, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants