Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.json #69

Closed
wants to merge 1 commit into from
Closed

Update composer.json #69

wants to merge 1 commit into from

Conversation

ro0NL
Copy link

@ro0NL ro0NL commented May 25, 2023

fixes #68

@ro0NL
Copy link
Author

ro0NL commented May 25, 2023

cc @dbu

@dbu
Copy link
Contributor

dbu commented May 25, 2023

some code rot (or rather testing rot) going in this repository. the latest tests fail but it seems to me it is because of some setup issue, not because of your change.

i was proposing to abandon the socket client as it is not actively maintained and should be upgraded to the PSR standards instead of php-http.

if you want to look into why the php tests fail, please do but unless a new maintainer steps up, i plan to abandon this client soonish.

@ro0NL
Copy link
Author

ro0NL commented May 25, 2023

it's currently part of crucial printer infrastructure on our side; https://github.com/etrias-nl/cups-ipp/blob/master/src/Transport/Client.php

i figured we are best of by embedding the socket client directly 👍

@ro0NL ro0NL closed this May 25, 2023
@ro0NL ro0NL deleted the patch-1 branch May 25, 2023 15:10
ro0NL added a commit to etrias-nl/cups-ipp that referenced this pull request May 30, 2023
@ro0NL
Copy link
Author

ro0NL commented May 30, 2023

for future reference, it's about psr/http-message NOT php-http/message 🤦

@dbu
Copy link
Contributor

dbu commented May 31, 2023

@ro0NL if you want, i can also give you commit rights on the php-http/socket-client if you want to keep maintaining it.

it is really more of a resource question that i want to abandon it, not that i think it should not exist.

@ro0NL
Copy link
Author

ro0NL commented May 31, 2023

sorry :) i believe everything should live under symfony/http-client umbrella 😅

im not sure it's currently possible with Symfony's NativeHttpClient, but perhaps that's the better migration path for this repository

otherwise just abandon it, the decision should be made tho ;)

@dbu
Copy link
Contributor

dbu commented May 31, 2023

this repository does not have a direct relation to symfony http clients... but if that is a good migration path for you, go for it. when we actually mark the repository as abandoned, you will have panicked users though, i am afraid :-/ (even though there is no need to panik, its not like we delete the repository in the next couple of years, only mark as abandoned...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal Compile Error: Declaration of Http\Client\Socket\Stream::close() must be compatible
2 participants