Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename erasmus to rigshospitalet (mpxv/rigshospitalet/2500/v1.0.0) #33

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

bede
Copy link
Collaborator

@bede bede commented Aug 26, 2024

Following discussion with Martin Pedersen, Matthijs Welkers and Anton van den Ouden, and @pvanheus, we understand that this scheme was created by Martin Pedersen while at Rigshospitalet in Copenhagen before distribution with other protocols.io authors. On this basis the name rigshospitalet was suggested and agreed, and Martin Schou Pedersen was added to the author list.

This PR therefore replaces references to erasmus with rigshospitalet in the scheme.

  • Use generic MPXV as primer prefix instead of erasmus
  • erasmus added as alias

The canonical name of the scheme therefore becomes:
mpxv/rigshospitalet/2500/v1.0.0

@bede bede changed the title Rename 'erasmus' to rigshospitalet (mpxv/rigshospitalet/2500/v1.0.0) Rename erasmus to rigshospitalet (mpxv/rigshospitalet/2500/v1.0.0) Aug 26, 2024
@pvanheus
Copy link
Collaborator

As per Bas Oude Munnik's email, we can remove the erasmus alias I think? I know it has (incorrectly) acquired that name but it is not in common use and seems to cause confusion.

@pvanheus
Copy link
Collaborator

As to the reference sequence - we note ON563414.3 as a reference but as per email discussions, Martin Schou Pedersen used an alignment of multiple sequences to generate the "reference" used for primer design. In the literature primers have been removed using cutadapt to trim from the ends: we need to be 100% sure that this reference is appropriate for the BED before merging.

@bede
Copy link
Collaborator Author

bede commented Sep 4, 2024

As agreed, merging to on basis of name change. If reference should be changed, this can be done in a future revision.

@bede bede closed this Sep 4, 2024
@bede bede reopened this Sep 4, 2024
@bede bede merged commit bd23c1b into main Sep 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants