-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SequenceConfigurationToConfigurationMetaPlanner #564
base: master
Are you sure you want to change the base?
Add SequenceConfigurationToConfigurationMetaPlanner #564
Conversation
I think the current way that we've been using this in It seems like the new way would be a sequence of |
src/planner/SequenceConfigurationToConfigurationMetaPlanner.cpp
Outdated
Show resolved
Hide resolved
src/planner/SequenceConfigurationToConfigurationMetaPlanner.cpp
Outdated
Show resolved
Hide resolved
include/aikido/planner/SequenceConfigurationToConfigurationMetaPlanner.hpp
Outdated
Show resolved
Hide resolved
Co-Authored-By: Brian Hou <[email protected]>
Co-Authored-By: Brian Hou <[email protected]>
@brianhou I'm not sure I fully followed.
Let me just share how I was initially hoping to use this. The other place is for That said, it's against the fail-fast policy, so I don't think it'd be wise to do it this way for Regardless, we'd need a similar solution to this if we want to pass any single problem meta planner into a |
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
==========================================
- Coverage 73.07% 72.97% -0.10%
==========================================
Files 219 220 +1
Lines 7865 7875 +10
==========================================
Hits 5747 5747
- Misses 2118 2128 +10
|
This PR adds
SequenceConfigurationToConfigurationMetaPlanner
, in preparation for #467.SequenceConfigurationToConfigurationMetaPlanner takes a list of
ConfigurationToConfigurationPlanner
and use them in sequence to solve aConfigurationToConfiguration
problem.While a generic
SequenceMetaPlanner
can be used to serve this purpose, we need this planner to be of typeConfigurationToConfigurationPlanner
in order to be used by PlannerAdapterConfigurationToConfiguration_to_ConfigurationToTSR
.Later, we may want to make a templated
SequenceMetaPlanner<T>
, but I'd leave it as a future TODO as it adds complexity.[Explain how this pull request was tested.]
TODO. I will test after the initial PR review.
Before creating a pull request
make format
Before merging a pull request
CHANGELOG.md