chore(React19): ran upgrade eslint and codemods#11508
Merged
tlabaj merged 3 commits intopatternfly:mainfrom Feb 12, 2025
Merged
chore(React19): ran upgrade eslint and codemods#11508tlabaj merged 3 commits intopatternfly:mainfrom
tlabaj merged 3 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11508.surge.sh A11y report: https://patternfly-react-pr-11508-a11y.surge.sh |
thatblindgeye
requested review from
a team,
mfrances17 and
tlabaj
and removed request for
a team
mfrances17
suggested changes
Feb 11, 2025
Contributor
mfrances17
left a comment
mfrances17
left a comment
There was a problem hiding this comment.
I tested this pretty thoroughly and there were no noticeable visual/behavioral issues, and no additional errors thrown in the console as a result of upgrading, so nice job. 👍
I do have a couple of comments regarding widespread use of any in these changes, which in general we should be avoiding when possible, since it's basically defeating the purpose of TS.
This was
linked to
issues
Feb 12, 2025
mfrances17
approved these changes
Feb 12, 2025
tlabaj
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #11483 , #11369, #11368
The eslint plug from 11483 only auto-updated the MockedTableChanges file (in react-table's test-helpers)
I also ran the React 19 codemod from their upgrade guide, which only auto-updated the Alert test file's
actimport.Everything else was autoupdated by the typescript React 19 codemod (I had to manually update 3 other instance of a useRef).
Additional issues: