Skip to content

fix(SearchInput): advanced search aria-expanded set by default #11494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thatblindgeye merged 2 commits into from
Feb 13, 2025
Merged

fix(SearchInput): advanced search aria-expanded set by default #11494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76de166
fix(SearchInput): advanced search aria-expanded set by default
nicolethoen Feb 3, 2025
33d1d22
update unit tests
nicolethoen Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/SearchInput/SearchInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ const SearchInputBase: React.FunctionComponent<SearchInputProps> = ({
onSearch,
onClear,
onToggleAdvancedSearch,
isAdvancedSearchOpen,
isAdvancedSearchOpen = false,
resultsCount,
onNextClick,
onPreviousClick,
Expand Down
25 changes: 22 additions & 3 deletions packages/react-core/src/components/SearchInput/__tests__/SearchInput.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ describe('SearchInput', () => {
onClear={props.onClear}
/>
);
const expandButton = screen.getByRole('button', { name: 'Open advanced search' });
expect(expandButton).toHaveAttribute('aria-expanded', 'false');

await user.click(screen.getByRole('button', { name: 'Search' }));

Expand Down Expand Up @@ -139,7 +141,12 @@ describe('SearchInput', () => {

await user.click(screen.getByRole('button', { name: 'Search' }));

await user.click(screen.getByRole('button', { name: 'Open advanced search' }));
const expandButton = screen.getByRole('button', { name: 'Open advanced search' });
expect(expandButton).toHaveAttribute('aria-expanded', 'false');

await user.click(expandButton);
expect(expandButton).toHaveAttribute('aria-expanded', 'true');

expect(screen.getByTestId('test-id')).toContainElement(screen.getByText('First name'));

expect(props.onSearch).toHaveBeenCalled();
Expand All @@ -149,7 +156,14 @@ describe('SearchInput', () => {
test('advanced search with custom attributes and appendTo="inline', async () => {
const user = userEvent.setup();

render(<SearchInput data-testid="test-id" attributes={[{ attr: 'test', display: 'test' }]} appendTo="inline" />);
render(
<SearchInput
data-testid="test-id"
attributes={[{ attr: 'test', display: 'test' }]}
advancedSearchDelimiter=":"
appendTo="inline"
/>
);

await user.click(screen.getByRole('button', { name: 'Open advanced search' }));

Expand All @@ -160,7 +174,12 @@ describe('SearchInput', () => {
const user = userEvent.setup();

render(
<SearchInput data-testid="test-id" attributes={[{ attr: 'test', display: 'test' }]} appendTo={document.body} />
<SearchInput
data-testid="test-id"
attributes={[{ attr: 'test', display: 'test' }]}
advancedSearchDelimiter=":"
appendTo={document.body}
/>
);

await user.click(screen.getByRole('button', { name: 'Open advanced search' }));
Expand Down
16 changes: 1 addition & 15 deletions ...s/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,13 +138,6 @@ exports[`SearchInput advanced search 1`] = `
</button>
</div>
</div>
<div
class=""
data-popper-escaped="true"
data-popper-placement="bottom-start"
data-popper-reference-hidden="true"
style="position: absolute; left: 0px; top: 0px; z-index: 9999; opacity: 0; transition: opacity 0ms cubic-bezier(.54, 1.5, .38, 1.11); min-width: 0px; transform: translate(0px, 0px);"
/>
</div>
</DocumentFragment>
`;
Expand Down Expand Up @@ -293,7 +286,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
data-popper-escaped="true"
data-popper-placement="bottom-start"
data-popper-reference-hidden="true"
style="position: absolute; top: 0px; left: 0px; transform: translate(0px, 0px); min-width: 0px; z-index: 9999; opacity: 1; transition: opacity 0ms cubic-bezier(.54, 1.5, .38, 1.11);"
style="position: absolute; left: 0px; top: 0px; z-index: 9999; opacity: 1; transition: opacity 0ms cubic-bezier(.54, 1.5, .38, 1.11); min-width: 0px; transform: translate(0px, 0px);"
>
<div
class="pf-v6-c-panel pf-m-raised"
Expand Down Expand Up @@ -621,13 +614,6 @@ exports[`SearchInput renders search input in strict mode 1`] = `
</button>
</div>
</div>
<div
class=""
data-popper-escaped="true"
data-popper-placement="bottom-start"
data-popper-reference-hidden="true"
style="position: absolute; left: 0px; top: 0px; z-index: 9999; opacity: 0; transition: opacity 0ms cubic-bezier(.54, 1.5, .38, 1.11); min-width: 0px; transform: translate(0px, 0px);"
/>
</div>
</DocumentFragment>
`;
Expand Down
Loading