fix(SearchInput): advanced search aria-expanded set by default#11494
Merged
thatblindgeye merged 2 commits intopatternfly:mainfrom Feb 13, 2025
Merged
fix(SearchInput): advanced search aria-expanded set by default#11494thatblindgeye merged 2 commits intopatternfly:mainfrom
thatblindgeye merged 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11494.surge.sh A11y report: https://patternfly-react-pr-11494-a11y.surge.sh |
dlabaj
approved these changes
Feb 6, 2025
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
This looks good 🎉 Could we just add a couple of tests that checks that aria-expanded is rendered false by default on the toggle button for an advanced search input, then is true when isAdvancedSearchOpen is true?
Contributor
Author
|
yes! |
thatblindgeye
approved these changes
Feb 13, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This was referenced Apr 12, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #11399