Ensure original named slot tags are retained when not using shadow root.

[patricknelson]

Setup to run unit tests.

[crisward]

Any chance you can remove the yarn.lock, not sure we need this with package-lock.json?

Otherwise looks good.

The tests use snowpack, which has since died. The only way to get the tests working for me is to do

nvm use 14
npm ci
npm test

It sounds like svelte 4 may make svelte-tag obsolete, otherwise I'd look to update the test runner.

[patricknelson]

Oh shoot! That's my fault, sorry about that. Comedy of errors. I ended up using yarn to link the package instead of npm since it was acting up (complaining about an "Unsupported engine", screenshot below) so I used yarn link to connect it to my project for testing (which resulted in yarn.lock).

And yeah just tried that (v14) and same error. I'm convinced it's an issue with the package and the fact that I'm on WSL2. Trying to launch a full blown GUI-based browser like that is a bit Rube Goldbergian IMHO. I wonder if Vitest would be better/faster at this (probably worth a shot later).

It sounds like svelte 4 may make svelte-tag obsolete, otherwise I'd look to update the test runner.

Maybe! I'm not sure. The reason I say that is because so far, svelte-tag seems to be working far better than Svelte v4. That said, I totally understand it's a WIP, however, there's a good argument for implementing it via a plugin like this. The reason why is because the core library is complicated. It's also far more difficult to reason about. It took me a long time to get setup and running with Svelte for development, then to reason about the issues, submit those issues (e.g. see my issues here, don't want to link directly to prevent cross referencing). On the flip side, I found svelte-tag to be far easier to get up and running, experiment with and etc. Also, we have to hope that the maintainers are willing/able to support things like HMR natively for custom elements, which I'm not certain about (since that's apparently not currently happening in v3 and v4, yet). I may submit an issue for that later. If you see in one of my issues (relating to customElements.define() compatibility), it turns out that I accidentally got HMR for free but then when I realized there was a "right" (blessed) way from the maintainers (i.e. Component.element) it didn't work with HMR 😞

Plus the upside to svelte-tag is that I'm already using it in production at ebayinc.com so I'm invested in finding a solution to the solving problems I encounter.

[patricknelson]

p.s. on the topic of unit testing, I've got a single experimental test up and running using vitest 😄 See:

• Successful test: https://github.com/patricknelson/svelte-tag/actions/runs/5160976719/jobs/9297564444#step:6:1
• Code in PR triggering it: Experimental WIP: Moving to Vitest with help of jsdom #2

Works on my machine locally as well as in Github's CI/Actions, so... should make it far easier for me to contribute and iterate since I can run the tests locally. Not sure about shadow DOM yet though (going to try that soon).

Edit: Thankfully it appears shadow DOM is working as expected! 👍

[patricknelson]

Alright, converted the repo over to using Vitest, see crisward/svelte-tag#14 😅

Determined to get that up and running so I can start cranking through some of the other issues in the repo (including the one relating to nested slots... got some ideas...).

[patricknelson]

Closing since crisward/svelte-tag#13 is merged.