Fix for #12: Ensure original named slot tags are retained when not using shadow root. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing shadow root. Only "unwrap" (i.e. from the host tag) when in the default slot. Including ignore of .idea/ files (JetBrains) and enforcing repo-specific whitespace rules (differs from my specific IDE settings)
patricknelson
commented
Jun 2, 2023
| slots[n.slot] = this.unwrap(n) | ||
| slots[n.slot] = n |
There was a problem hiding this comment.
This is the primary change, the rest is whitespace (or unit test updates).
|
p.s. @crisward I cannot run the unit tests on my machine (WSL2 on Win10). Can you double check these for me really quick and let me know? Edit: Oops, never mind, I see you've got actions enabled. 😅 Just validated on Github: https://github.com/patricknelson/svelte-tag/actions/runs/5151576479/jobs/9276874029?pr=1 |
|
Some additional discussion here (just the PR I'm using for unit tests): patricknelson/svelte-retag#1 |
patricknelson
referenced
this pull request
in patricknelson/svelte-retag
Jun 5, 2023
…en not using shadow root. Take 2 required to account for new unit testing framework (Vitest) from PR #13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #12.
Ensure original named slot tags are retained when not using shadow root. Only "unwrap" (i.e. from the host tag) when in the default slot. This PR isn't as significant as it looks since it's only altering a single line, the rest is whitespace: https://github.com/crisward/svelte-tag/pull/13/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346L98-R98
That said, I'm doing a few other minor things in the PR (making it easier to contribute):
.idea/files (JetBrains specific).editorconfig), hope this is ok.