Skip to content

refactor: Upgrade @aws-sdk/s3-request-presigner from 3.787.0 to 3.815.0 #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 43 additions & 67 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"homepage": "https://github.com/parse-community/parse-server-s3-adapter#readme",
"dependencies": {
"@aws-sdk/client-s3": "3.824.0",
"@aws-sdk/s3-request-presigner": "3.787.0"
"@aws-sdk/s3-request-presigner": "3.815.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Validate the security update and run dependency audit.

After bumping the presigner package, reinstall dependencies and run an audit to confirm the Snyk-reported vulnerability is resolved and no new issues have been introduced.


🏁 Script executed:

#!/bin/bash
npm ci
npm audit

Length of output: 9815


Remaining vulnerabilities detected after audit

The npm audit report shows 15 unresolved issues (including 2 critical and 4 high) related to transitive dependencies of @aws-sdk/s3-request-presigner bump:

• Critical:
– crypto-js (PBKDF2 weakness)
• High:
– cross-spawn (ReDoS)
– path-to-regexp (ReDoS)
– ws (DoS via headers)
– others

Action items:

  • Run npm audit fix to address non-breaking issues.
  • For fixes marked “--force” (breaking changes), evaluate upgrading/removing the following top-level dependencies:
    • parse & parse-server (crypto-js, ws, tough-cookie)
    • express (path-to-regexp)
    • @babel/runtime & helpers (named group RegExp issue)
  • After upgrades, rerun npm ci && npm audit to confirm zero vulnerabilities.

Please prioritize resolving or safely mitigating the remaining findings before merging.

🤖 Prompt for AI Agents
In package.json at line 23, after updating the @aws-sdk/s3-request-presigner
dependency, run npm ci and npm audit to identify remaining vulnerabilities. Then
run npm audit fix to automatically resolve non-breaking issues. For
vulnerabilities requiring breaking changes, evaluate upgrading or removing
top-level dependencies such as parse, parse-server, express, and @babel/runtime
as indicated. After making these changes, reinstall dependencies and rerun npm
audit to ensure all vulnerabilities are resolved before merging.

},
"devDependencies": {
"@semantic-release/changelog": "6.0.3",
Expand Down