-
-
Notifications
You must be signed in to change notification settings - Fork 87
refactor: Upgrade @aws-sdk/s3-request-presigner from 3.787.0 to 3.815.0 #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Upgrade @aws-sdk/s3-request-presigner from 3.787.0 to 3.815.0 #284
Conversation
Snyk has created this PR to upgrade @aws-sdk/s3-request-presigner from 3.787.0 to 3.815.0. See this package in npm: @aws-sdk/s3-request-presigner See this project in Snyk: https://app.snyk.io/org/acinader/project/3364151b-9c9a-4458-9afd-809dc5309438?utm_source=github&utm_medium=referral&page=upgrade-pr
I will reformat the title to use the proper commit message syntax. |
🚀 Thanks for opening this pull request! |
📝 WalkthroughWalkthroughThe dependency "@aws-sdk/s3-request-presigner" in the package.json file was updated from version 3.787.0 to 3.815.0. No other files or dependencies were modified. Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #284 +/- ##
=======================================
Coverage 97.19% 97.19%
=======================================
Files 2 2
Lines 214 214
=======================================
Hits 208 208
Misses 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package.json (1)
23-23
: Ensure AWS SDK version compatibility across packages.The
@aws-sdk/client-s3
dependency is pinned at3.824.0
while@aws-sdk/s3-request-presigner
is updated to3.815.0
. Mixing minor versions can introduce subtle API mismatches—consider aligning both to the same minor version (e.g.,3.824.0
) or verifying compatibility between these releases.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.json
is excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: Parse Server 7, Node.js 20
- GitHub Check: Parse Server 8, Node.js 20
- GitHub Check: Parse Server 8, Node.js 18
- GitHub Check: Parse Server 7, Node.js 22
- GitHub Check: Parse Server 8, Node.js 22
- GitHub Check: Parse Server 7, Node.js 18
@@ -20,7 +20,7 @@ | |||
"homepage": "https://github.com/parse-community/parse-server-s3-adapter#readme", | |||
"dependencies": { | |||
"@aws-sdk/client-s3": "3.824.0", | |||
"@aws-sdk/s3-request-presigner": "3.787.0" | |||
"@aws-sdk/s3-request-presigner": "3.815.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Validate the security update and run dependency audit.
After bumping the presigner package, reinstall dependencies and run an audit to confirm the Snyk-reported vulnerability is resolved and no new issues have been introduced.
🏁 Script executed:
#!/bin/bash
npm ci
npm audit
Length of output: 9815
Remaining vulnerabilities detected after audit
The npm audit
report shows 15 unresolved issues (including 2 critical and 4 high) related to transitive dependencies of @aws-sdk/s3-request-presigner
bump:
• Critical:
– crypto-js (PBKDF2 weakness)
• High:
– cross-spawn (ReDoS)
– path-to-regexp (ReDoS)
– ws (DoS via headers)
– others
Action items:
- Run
npm audit fix
to address non-breaking issues. - For fixes marked “--force” (breaking changes), evaluate upgrading/removing the following top-level dependencies:
• parse & parse-server (crypto-js, ws, tough-cookie)
• express (path-to-regexp)
• @babel/runtime & helpers (named group RegExp issue) - After upgrades, rerun
npm ci && npm audit
to confirm zero vulnerabilities.
Please prioritize resolving or safely mitigating the remaining findings before merging.
🤖 Prompt for AI Agents
In package.json at line 23, after updating the @aws-sdk/s3-request-presigner
dependency, run npm ci and npm audit to identify remaining vulnerabilities. Then
run npm audit fix to automatically resolve non-breaking issues. For
vulnerabilities requiring breaking changes, evaluate upgrading or removing
top-level dependencies such as parse, parse-server, express, and @babel/runtime
as indicated. After making these changes, reinstall dependencies and rerun npm
audit to ensure all vulnerabilities are resolved before merging.
Snyk has created this PR to upgrade @aws-sdk/s3-request-presigner from 3.787.0 to 3.815.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 13 versions ahead of your current version.
The recommended version was released 22 days ago.
Release notes
Package name: @aws-sdk/s3-request-presigner
3.815.0(2025-05-21)
Documentation Changes
New Features
Tests
For list of updated packages, view updated-packages.md in assets-3.815.0.zip
3.812.0(2025-05-16)
Documentation Changes
New Features
Bug Fixes
Tests
For list of updated packages, view updated-packages.md in assets-3.812.0.zip
3.810.0(2025-05-14)
Chores
New Features
For list of updated packages, view updated-packages.md in assets-3.810.0.zip
3.808.0(2025-05-12)
Chores
New Features
For list of updated packages, view updated-packages.md in assets-3.808.0.zip
3.806.0(2025-05-08)
Chores
Documentation Changes
New Features
Bug Fixes
Tests
For list of updated packages, view updated-packages.md in assets-3.806.0.zip
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
Summary by CodeRabbit