Avoid repeated initialization of the shim module #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nforro
force-pushed
the
initialization
branch
from
ac87960 to
bed3e4b
Compare
When the shim module tries to reload itself, it repeats the loop of trying all the sitepackages directories, and because importlib.reload() is noop when called recursively, it ends up raising ImportError that is visible to the user. Even though execution returns to the original loop and the system RPM module is loaded successfully, the error message produced is very confusing. Improve that by avoiding repeated initialization of the shim module. Also make sure that importlib.reload(), when loading the shim module for the second time, throws a specific exception that doesn't trigger any log message, to make things even less confusing. Signed-off-by: Nikola Forró <[email protected]>
Importing the shim should be silent. If the system RPM module fails to import, ImportError will be raised, and that makes it clear that the process failed. Signed-off-by: Nikola Forró <[email protected]>
nforro
force-pushed
the
initialization
branch
from
bed3e4b to
36e8a42
Compare
The trick with the global variable to prevent repeated initialization comes from the documentation: The fact that |
|
Zuul is still not enabled for this project, merging manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the shim module tries to reload itself, it repeats the loop of trying all the sitepackages directories, and because
importlib.reload()is noop when called recursively, it ends up raisingImportErrorthat is visible to the user.Even though execution returns to the original loop and the system RPM module is loaded successfully, the error message produced is very confusing.
Improve that by avoiding repeated initialization of the shim module. Also make sure that
importlib.reload(), when loading the shim module for the second time, throws a specific exception that doesn't trigger any log message, to make things even less confusing.