Avoid printing any log messages unless log level is DEBUG

Importing the shim should be silent. If the system RPM module fails to import, ImportError will be raised, and that makes it clear that the process failed. Signed-off-by: Nikola Forró <[email protected]>
packit · Feb 10, 2023 · 36e8a42 · 36e8a42
1 parent f0978c7
commit 36e8a42
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/rpm/__init__.py b/rpm/__init__.py
@@ -88,10 +88,13 @@ def initialize() -> None:
         except ShimAlreadyInitializingError:
             continue
         except Exception as e:
-            logger.error(f"Exception: {e}")
+            logger.debug(f"Exception: {type(e)}: {e}")
             continue
     else:
-        raise ImportError("Failed to import system RPM module")
+        raise ImportError(
+            "Failed to import system RPM module. "
+            "Make sure RPM Python bindings are installed on your system."
+        )
 
 
 # avoid repeated initialization of the shim module