Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies, progenitor to dfc6e0f2, oxide.json to omicron:33bbad37 #915

Merged
merged 11 commits into from
Nov 15, 2024
Merged
64 changes: 42 additions & 22 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions cli/src/cli_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -577,8 +577,8 @@ fn xxx<'a>(command: CliCommand) -> Option<&'a str> {
CliCommand::ProbeView => Some("experimental probe view"),

// Metrics-related subcommands
CliCommand::TimeseriesQuery => Some("experimental timeseries query"),
CliCommand::TimeseriesSchemaList => Some("experimental timeseries schema list"),
CliCommand::SystemTimeseriesQuery => Some("experimental timeseries query"),
CliCommand::SystemTimeseriesSchemaList => Some("experimental timeseries schema list"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaning against adding system here — it's already experimental and I'm not sure we're going to bother adding the project-scoped one from oxidecomputer/omicron#6873 when it lands.


// Commands not yet implemented
CliCommand::DeviceAccessToken
Expand Down
12 changes: 9 additions & 3 deletions cli/src/cmd_net.rs
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ pub struct CmdLinkAdd {

/// The forward error correction mode of the link.
#[arg(long, value_enum)]
pub fec: CliLinkFec,
pub fec: Option<CliLinkFec>,

/// Maximum transmission unit for the link.
#[arg(long, default_value_t = 1500u16)]
Expand Down Expand Up @@ -126,7 +126,7 @@ impl AuthenticatedCmd for CmdLinkAdd {
});
let link = LinkConfigCreate {
autoneg: self.autoneg,
fec: self.fec.into(),
fec: self.fec.map(|fec| fec.into()),
mtu: self.mtu,
speed: self.speed.into(),
lldp: LldpLinkConfigCreate {
Expand Down Expand Up @@ -1248,7 +1248,13 @@ impl AuthenticatedCmd for CmdPortConfig {
)?;

for l in &config.links {
writeln!(&mut tw, "{:?}\t{:?}\t{:?}", l.autoneg, l.fec, l.speed,)?;
writeln!(
&mut tw,
"{}\t{}\t{}",
l.autoneg,
l.fec.map_or("<auto>".to_string(), |fec| fec.to_string()),
l.speed,
)?;
}
tw.flush()?;
println_nopipe!();
Expand Down
4 changes: 2 additions & 2 deletions cli/src/cmd_timeseries/dashboard.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use crossterm::event::{Event, EventStream, KeyCode, KeyEvent, KeyEventKind, KeyM
use futures::{FutureExt, StreamExt};
use oxide::{
types::{MetricType, Table as OxqlTable, Timeseries, TimeseriesQuery, ValueArray},
Client, ClientMetricsExt,
Client, ClientSystemMetricsExt,
};
use ratatui::{
prelude::{Alignment, Constraint, Direction, Layout},
Expand Down Expand Up @@ -218,7 +218,7 @@ async fn client_query_loop(
_ = &mut done => break,
_ = interval.tick() => {
let request = client
.timeseries_query()
.system_timeseries_query()
.body(TimeseriesQuery { query: query.clone() });
match request.send().await {
Ok(response) => {
Expand Down
Loading
Loading