-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies, progenitor to dfc6e0f2, oxide.json to omicron:33bbad37 #915
Conversation
Hey @Nieuwejaar, could you check my fixes for the optional FEC link thing in 5c6e928? Wasn't sure if it should be |
CliCommand::TimeseriesQuery => Some("experimental timeseries query"), | ||
CliCommand::TimeseriesSchemaList => Some("experimental timeseries schema list"), | ||
CliCommand::SystemTimeseriesQuery => Some("experimental timeseries query"), | ||
CliCommand::SystemTimeseriesSchemaList => Some("experimental timeseries schema list"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaning against adding system
here — it's already experimental and I'm not sure we're going to bother adding the project-scoped one from oxidecomputer/omicron#6873 when it lands.
Either one would be valid, but using one of each would give broader test coverage. |
That occurred to me, will do it. |
0cd9f85
to
b729c30
Compare
had to update a snapshot
|
Autoneg Fec Speed | ||
false None Speed100G | ||
Autoneg Fec Speed | ||
false Some(None) Speed100G |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like odd output from this command. I'll look into it
switch0/qsfp0 | ||
============= | ||
Autoneg Fec Speed | ||
false None Speed100G | ||
Autoneg Fec Speed | ||
false <auto> speed100_g | ||
|
||
Address Lot VLAN | ||
169.254.10.2/30 initial-infra None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rcgoodfellow I changed this to have what I thought was more reasonable output (i.e. not using Debug). If you don't like it, please let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me
Lock file updated
Bump progenitor from
789c4b66
todfc6e0f2
Changes: oxidecomputer/progenitor@789c4b6...dfc6e0f
Generated code against nexus.json
33bbad37