Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigned download modal, with enhanced data download options #4078

Merged
merged 44 commits into from
Nov 5, 2024

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Oct 23, 2024

Implements #4015.

Open questions for review:

  • (Design) Given that the code examples block is usually below-the-fold anyways, does it being expandable/collapsible even make sense?
  • (Design) Should we show csv/zip icons next to the download button as a visual aid?
  • (Design) Should there be an easy way to see/copy the csv and metadata link?
  • Should we restore explorer downloadDataLink functionality? (see Slack)
    • If not, get rid of downloadDataLink / externalCsvLink code
  • Have P&D proof-read all the copy contained in the modal

TODOs

  • Make Modal less jumpy when switching tabs / loading
  • Redesigned Source citation section, including different copy
  • Place copy-able csv/metadata links atop the code examples section
  • (Potentially) remove collapse/expand from code examples
  • (Potentially) show icon next to button
  • Move download options into code examples section
  • Make DL buttons download ZIP file for full/current data
  • Este's suggestion: "Full/Long" and "short/abbreviated" column names, rather than "verbose"
  • Include link to Data API documentation
  • Incorporate Slack design feedback
  • Incorporate API versioning?
  • Check font weights - especially download button descriptions look way heavier than in the design
  • Check analytics instrumentation: Make sure we track every interesting click

There's quite a large state space, which I want to illustrate here to some degree:

Description Screenshot Example URL
"Normal" vis tab

CleanShot 2024-10-25 at 13 50 57

http://staging-site-download-tab-redesign/grapher/life-expectancy

"Normal" data tab

CleanShot 2024-10-25 at 13 51 40

http://staging-site-download-tab-redesign/grapher/life-expectancy

http://staging-site-download-tab-redesign/grapher/electricity-prod-source-stacked?country=~DEU

Short names not available (pre-ETL dataset or csv-based explorer)

CleanShot 2024-10-25 at 13 52 40

http://staging-site-download-tab-redesign/grapher/mode-of-reporting-literacy-rates

http://staging-site-download-tab-redesign/explorers/migration-flows

Vis download not possible, because on table tab

CleanShot 2024-10-25 at 13 53 00

http://staging-site-download-tab-redesign/grapher/life-expectancy?tab=table

Data is non-redistributable

CleanShot 2024-10-25 at 13 53 20

http://staging-site-download-tab-redesign/explorers/covid?Metric=Variants&Interval=Cumulative&Relative+to+population=true

http://staging-site-download-tab-redesign/grapher/suicide-vs-violent-deaths

Server-side csv not available

http://staging-site-download-tab-redesign/explorers/covid

@owidbot
Copy link
Contributor

owidbot commented Oct 24, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-download-tab-redesign

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-10-24 10:12:16 UTC
Execution time: 1.15 seconds

@marcelgerber marcelgerber marked this pull request as ready for review October 25, 2024 12:04
@marcelgerber
Copy link
Member Author

@danyx23 Aside from a few small tweaks that came up on Slack, this is now close to being merged. Could you take another quick look?

Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice, thanks for your tweaks, Marcel! I left a few suggestions for alternative wording. I think this is basically good to go - maybe Marwa could have one last look at it in terms of visual polish.

@marcelgerber marcelgerber merged commit 123a261 into master Nov 5, 2024
13 of 14 checks passed
@marcelgerber marcelgerber deleted the download-tab-redesign branch November 5, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants