Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycle 2024.6: Refreshed Grapher download UI that uses server side csv generation #4015

Closed
4 of 7 tasks
danyx23 opened this issue Oct 4, 2024 · 1 comment
Closed
4 of 7 tasks

Comments

@danyx23
Copy link
Contributor

danyx23 commented Oct 4, 2024

Make it easy for our power-users to download our data and use it in code

This is follow up work to the server side one tracked in #3648.

Motivation

We recently added the ability to generate csv and zip file downloads in CF functions (#3613). Marwa has designed a new data tab for the download modal in grapher that makes use of the functions that are now possible and shows how to use the data from code (Figma file).

We now want to finish the UI so that users can make use of this feature.

Proposed scope

Modify the download modal of the Grapher to have two tabs - one for the data viz (that we have already) and one for the data download with a few more options and code examples.

Must do

Could do

Open questions

Technical notes

The code snippets should change according to the options the user selects (full data vs only visible, short column names or verbose ones).

There is an early draft PR (#4014) of such a UI change that I used during development of the server side feature. Feel free to use it or start fresh.

danyx23 added a commit that referenced this issue Oct 10, 2024
This PR adds functionality to generate a CSV file on the server in a CF worker for the data of any chart. It also allows downloading a metadata.json file, a readme.md and a zip file of all three of these things. 

This is in preparation of surfacing these things in the download UI of grapher in the upcoming cycle 2024.6 (#4015). This PR does not make any use of the new CF functions endpoints yet and the download UI is not yet changed. 

This PR implements #3648 

## Testing

To test this, try http get requests against `/grapher/SLUG.zip`, `/grapher/SLUG.csv`, `/grapher/SLUG.metadata.json` at localhost:8788, or at the staging server linked below.

There is also an observable notebook that lets you browse the generated readme files in an easier way: https://observablehq.com/d/d410e9b2d2b7c330
@marcelgerber
Copy link
Member

Implemented in #4078.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants