Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add CF function for getting SLUG.config.json #3870

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Aug 13, 2024

This PR adds routing to the /grapher/SLUG.ts function and adds an endpoint in the form /grapher/SLUG.config.json that just returns the grapher config from R2. It takes redirects into account, just like the related function that rewrites the HTML to have dynamic thumbnails.

Copy link
Contributor Author

danyx23 commented Aug 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @danyx23 and the rest of your teammates on Graphite Graphite

@owidbot
Copy link
Contributor

owidbot commented Aug 13, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-fetch-grapher-config-from-r2

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-09-09 14:52:53 UTC
Execution time: 1.22 seconds

@danyx23 danyx23 force-pushed the danyx23/push-chart-config-to-local-dev branch from 5bb7b6f to 13bceeb Compare August 13, 2024 20:21
@danyx23 danyx23 force-pushed the fetch-grapher-config-from-r2 branch 2 times, most recently from 2ba99e8 to 4c2c37c Compare August 13, 2024 20:50
@danyx23 danyx23 changed the base branch from danyx23/push-chart-config-to-local-dev to danyx23/add-subcommand-to-sync-graphers-to-r2 August 13, 2024 20:50
@danyx23 danyx23 marked this pull request as ready for review August 13, 2024 21:01
@danyx23 danyx23 force-pushed the danyx23/add-subcommand-to-sync-graphers-to-r2 branch from 22eaef8 to 958e4fa Compare August 14, 2024 09:46
@danyx23 danyx23 force-pushed the fetch-grapher-config-from-r2 branch from 4c2c37c to ee9fbaa Compare August 14, 2024 09:46
@danyx23 danyx23 force-pushed the danyx23/add-subcommand-to-sync-graphers-to-r2 branch from 958e4fa to e35e11e Compare August 15, 2024 15:00
@danyx23 danyx23 force-pushed the fetch-grapher-config-from-r2 branch 2 times, most recently from 8d1d522 to b6f5d2e Compare August 15, 2024 17:01
@danyx23 danyx23 changed the base branch from danyx23/add-subcommand-to-sync-graphers-to-r2 to use-r2-in-cf-functions August 15, 2024 17:01
@danyx23 danyx23 force-pushed the fetch-grapher-config-from-r2 branch from b6f5d2e to 904a0b6 Compare August 15, 2024 17:11
@danyx23 danyx23 force-pushed the fetch-grapher-config-from-r2 branch 3 times, most recently from 6148254 to d868f99 Compare August 15, 2024 20:06
@danyx23 danyx23 force-pushed the fetch-grapher-config-from-r2 branch from d868f99 to df600ae Compare August 19, 2024 14:59
@danyx23 danyx23 changed the base branch from use-r2-in-cf-functions to graphite-base/3870 September 10, 2024 10:34
@danyx23 danyx23 changed the base branch from graphite-base/3870 to master September 10, 2024 10:35
Copy link
Contributor Author

danyx23 commented Sep 10, 2024

Merge activity

  • Sep 10, 6:53 AM EDT: @danyx23 started a stack merge that includes this pull request via Graphite.
  • Sep 10, 6:54 AM EDT: @danyx23 merged this pull request with Graphite.

@danyx23 danyx23 merged commit d6b9646 into master Sep 10, 2024
21 checks passed
@danyx23 danyx23 deleted the fetch-grapher-config-from-r2 branch September 10, 2024 10:54
@danyx23 danyx23 linked an issue Oct 4, 2024 that may be closed by this pull request
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store chart configs in R2, add retrieval at /grapher/SLUG.config.json
3 participants