Add storing single charts to local R2 bucket to syncGraphersToR2 tool #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyx23
force-pushed
the
danyx23/add-subcommand-to-sync-graphers-to-r2
branch
from
ed7d910
to
a7ad2fb
Compare
danyx23
force-pushed
the
danyx23/push-chart-config-to-local-dev
branch
from
92d502e
to
0777704
Compare
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
danyx23
force-pushed
the
danyx23/add-subcommand-to-sync-graphers-to-r2
branch
from
a7ad2fb
to
03be17a
Compare
danyx23
force-pushed
the
danyx23/push-chart-config-to-local-dev
branch
from
0777704
to
658bd0a
Compare
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-08-13 16:49:34 UTC |
danyx23
force-pushed
the
danyx23/add-subcommand-to-sync-graphers-to-r2
branch
from
03be17a
to
57be3d9
Compare
danyx23
force-pushed
the
danyx23/push-chart-config-to-local-dev
branch
from
658bd0a
to
3dbf32c
Compare
… that it supports multiple commands Add support for multiple commands in `syncGraphersToR2.ts` script. * **Refactor existing implementation:** - Move the existing implementation to the "sync" subcommand. - Update the `main` function to handle the new subcommand structure. - Parse the command-line arguments to determine which subcommand to execute. * **Add new subcommand:** - Add a new "store-dev-by-slug" subcommand with a dummy implementation. - Add a help message for the new subcommand. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/owid/owid-grapher?shareId=XXXX-XXXX-XXXX-XXXX).
The syncGraphersToR2 tool let's you sync all needed entries from the chart_configs table to an actual R2 bucket. This is useful for production and staging servers but in local dev the R2 bindings currently can't connect to an actual R2 bucket and instead simulate one using a local folder. This PR adds a tool to store single chart configs by slug from the database into the local R2 bucket by invoking the `wrangler` cli tool for storing R2 objects. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/owid/owid-grapher?shareId=XXXX-XXXX-XXXX-XXXX).
danyx23
force-pushed
the
danyx23/add-subcommand-to-sync-graphers-to-r2
branch
from
57be3d9
to
cc54317
Compare
danyx23
force-pushed
the
danyx23/push-chart-config-to-local-dev
branch
from
5bb7b6f
to
13bceeb
Compare
danyx23
force-pushed
the
danyx23/add-subcommand-to-sync-graphers-to-r2
branch
2 times, most recently
from
22eaef8
to
958e4fa
Compare
danyx23
force-pushed
the
danyx23/add-subcommand-to-sync-graphers-to-r2
branch
from
958e4fa
to
e35e11e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syncGraphersToR2 tool let's you sync all needed entries from the chart_configs table to an actual R2 bucket. This is useful for production and staging servers but in local dev the R2 bindings currently can't connect to an actual R2 bucket and instead simulate one using a local folder.
This PR adds a tool to store single chart configs by slug from the database into the local R2 bucket by invoking the
wranglercli tool for storing R2 objects.For more details, open the Copilot Workspace session.