Fix new author creation error on socials #3578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0Number of differences (all views): 0 Edited: 2024-05-06 14:05:32 UTC |
mlbrgl
force-pushed
the
fix-author-creation
branch
from
b23f0f8
to
45dfd27
Compare
mlbrgl
force-pushed
the
fix-author-creation
branch
from
45dfd27
to
5e7f5cb
Compare
mlbrgl
force-pushed
the
fix-author-creation
branch
from
5e7f5cb
to
97878f4
Compare
ikesau
approved these changes
May 8, 2024
|
If this is causing issues in other places, could you update all the other GdocBase inheritors to use |
|
I like the verbose comments :) - thanks for fixing this, Matthieu! I agree that it would be nice to do this for all classes already in this PR |
|
yes, I'm indeed using long comments as a warning and a deterrent: the longer the comment the more I'll think about changing this line in the future 😄 thank you both for the review, I've updated the other classes. |
mlbrgl
added a commit
that referenced
this pull request
May 17, 2024
… overridden in Object.assign (#3600) *alternate solution to #3578, which had to be reverted because [this.content in GdocPost](https://github.com/owid/owid-grapher/blob/3691a52abfa41b34d7853df84df3329d80a9a187/db/model/Gdoc/GdocPost.ts#L34-L36) would be honored by _.defaults as a property not to override, but would result in the `content` property not respecting `OwidGdocContent` at run time.* ### What changed? This PR promotes GdocBase instance-level functions (e.g. `_enrichSubclassContent` as class methods. ### Why make this change? GdocAuthor (but also GdocPost, GdocHomepage and Gdoc DataInsight) are created from a GdocBase instance (only when inserting a new Gdoc) using `Object.assign(gdocAuthor, gdocBase)`. This call lists all enumerable properties on GdocBase, including instance-level functions such as `_enrichSubclassContent`, and overrides the subclass version. This leads to the subclass enrichment not being performed, and in the case of author creation, an error. ## Follow-up Promoting instance-level functions to class methods on `GdocBase` is enough to solve this issue, but we should consider whether to apply the same treatment to the GdocBase subclasses too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3576
Both
GdocBaseinstances andOwidGdocBaseInterfaceobjects implement the same interface. However, GdocBase instances leak methods intoloadGdocFromGdocBase, which override subclasses implementations.With regards to overriding the
GdocAuthorsubclass with an instance of the parent class, three approaches have been reviewed:defaults(see description in code)omitBy(see description in code)This PR only fixes GdocAuthor, but we should expand this to all Gdoc* subclasses created by the
loadGdocFromGdocBasefactory function.